Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't understand the livenessProbe example, Can you explain it in detail? #47

Open
egege opened this issue Jul 19, 2021 · 3 comments
Open
Labels
question Further information is requested

Comments

@egege
Copy link

egege commented Jul 19, 2021

https://github.com/renatomefi/php-fpm-healthcheck#livenessprobe

--listen-queue=10 # fails if there are more than 10 processes waiting in the fpm queue
In this case, pod should be scaleUp, rather than reset?

--accepted-conn=5000 # fails after fpm has served more than 5k requests, this will force the pod to reset, use with caution
In this case, pod don't have to reset., Why do you configure it this way?

So how do you configure it in production?

@wandersonwhcr wandersonwhcr added the question Further information is requested label Jan 5, 2022
@wandersonwhcr
Copy link
Collaborator

Hello @egege !

I think we have a doc problem here, because if php-fpm-healthcheck fails, pod will be marked as unhealthy.

I'll try to simulate this behavior.

@beschoenen
Copy link

My confusion here is, shouldn't the --listen-queue option be on the readinessProbe? You don't want the pod to be killed, but you want to wait for it to finish off the queue before it getting new requests to handle.

@RoSk0
Copy link

RoSk0 commented Nov 24, 2023

Completely agree with @beschoenen - my understanding that those probes in the examples should be swapped:

  • livenessProbe - php-fpm-healthcheck # a simple ping since this means it's ready to handle traffic
  • readinessProbe - --listen-queue=10 # fails if there are more than 10 processes waiting in the fpm queue - we want to wait until the queue reduces before sending more traffic to the pod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants