renovate helmfile "skipReason": "unsupported-chart-type" with oci private repos (got it working but please provide insights))

[machecazzon]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

Was this something which used to work for you, and then stopped?

None

Describe the problem

Hi,

I am having trouble with helmfile using private OCI repos.
All works well with public repos. Using helmfile cli directly all works fine (public/private oci repos) but facing some issue using private oci repos from helmfile with renovate preset.

The same pull from the private oci repo works just fine for dockerfile and helmv3 presets but can't make for helmfile one. Whatever i do to try manipulate it using docker.io registry or Google Artifact Registry it always ends with skipReason": "unsupported-chart-type"

Spent quite a bit of time trying different things around but ending with same results and this is the current statuses:

• looks is not not an auth related problem
• it works perfectly with dockerfile, helmv3 and helmfile presets with PUBLIC OCI REPOS
• it does not work for helmfile but works for dockerfile, helmv3 presets with PRIVATE OCI REPOS

Note: on logs output dockerfile is using a Dockerfile with FROM directive pointing to the helm chart for testing purposes and verify it works.

helmfile using private repo. Using helmfile cli it works perfectly.

---
repositories:
- name: docker.io
  url: docker.io
  oci: true

releases:
- name: test-chart
  namespace: test
  chart: docker.io/replaceme/test-chart
  version: 0.1.0

Any help on this appreciate.

Thanks

Relevant debug logs

Logs

Here is the relevant bit of output

DEBUG: packageFiles with updates
{
  "baseBranch": "main"
  "config": {
    "dockerfile": [
      {
        "deps": [
          {
            "depName": "docker.io/replaceme/test-chart",
            "currentValue": "0.1.0",
            "replaceString": "docker.io/replaceme/test-chart:0.1.0",
            "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
            "datasource": "docker",
            "depType": "final",
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "0.2.0",
                "newValue": "0.2.0",
                "newMajor": 0,
                "newMinor": 2,
                "updateType": "minor",
                "branchName": "renovate/docker.io-replaceme-test-chart-0.x"
              }
            ],
            "packageName": "docker.io/replaceme/test-chart",
            "versioning": "docker",
            "warnings": [],
            "registryUrl": "https://index.docker.io",
            "currentVersion": "0.1.0",
            "isSingleVersion": true,
            "fixedVersion": "0.1.0"
          }
        ],
        "packageFile": "Dockerfile"
      }
    ],
    "helmfile": [
      {
        "deps": [
          {
            "depName": "replaceme/test-chart",
            "currentValue": "0.1.0",
            "registryUrls": [
              "docker.io"
            ],
            "datasource": "docker",
            "packageName": "docker.io/replaceme/test-chart",
            "skipReason": "unsupported-chart-type",
            "updates": []
          }
        ],
        "datasource": "helm",
        "packageFile": "helmfile.yaml"
      }
    ],
    "helmv3": [
      {
        "deps": [
          {
            "depName": "test-chart",
            "currentValue": "0.1.0",
            "datasource": "docker",
            "packageName": "docker.io/replaceme/test-chart",
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "0.2.0",
                "newValue": "0.2.0",
                "newMajor": 0,
                "newMinor": 2,
                "updateType": "minor",
                "branchName": "renovate/test-chart-0.x"
              }
            ],
            "versioning": "docker",
            "warnings": [],
            "registryUrl": "https://index.docker.io",
            "currentVersion": "0.1.0",
            "isSingleVersion": true,
            "fixedVersion": "0.1.0"
          }
        ],
        "datasource": "helm",
        "packageFileVersion": "0.1.0",
        "packageFile": "Chart.yaml"
      }
    ]
  }
}

using helmfile cli:

helmfile deps .
Logging in to registry
Pulling docker.io/replaceme/test-chart:0.1.0
Updating dependency /var/folders/s1/7qw_wynd0ljdwf9l51dbs2cm0000gq/T/helmfile3051808230/test-project/test-chart/replaceme/test-chart/0.1.0/test-chart
Updating dependency /var/folders/s1/7qw_wynd0ljdwf9l51dbs2cm0000gq/T/1126403861
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading boostrack/test-chart from repo oci://docker.io
Deleting outdated charts

This might be the trigger point

renovate/lib/modules/manager/helmfile/extract.ts

Line 140 in 74014fd

res.skipReason = 'unsupported-chart-type';

Doing some changes into helmfile to end up closer to the reported by helmv3 output namely "depName": "replaceme/test-chart" to be just "depName": "test-chart"

helmfile

---
repositories:
- name: docker.io
  url: docker.io/replaceme
  # url: docker.io
  oci: true

releases:
- name: test-chart
  namespace: test
  chart: docker.io/test-chart
  # chart: docker.io/replaceme/test-chart

ends up with

{
  "baseBranch": "main"
  "config": {
    "dockerfile": [
      {
        "deps": [
          {
            "depName": "docker.io/replaceme/test-chart",
            "currentValue": "0.1.0",
            "replaceString": "docker.io/replaceme/test-chart:0.1.0",
            "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
            "datasource": "docker",
            "depType": "final",
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "0.2.0",
                "newValue": "0.2.0",
                "newMajor": 0,
                "newMinor": 2,
                "updateType": "minor",
                "branchName": "renovate/docker.io-replaceme-test-chart-0.x"
              }
            ],
            "packageName": "docker.io/replaceme/test-chart",
            "versioning": "docker",
            "warnings": [],
            "registryUrl": "https://index.docker.io",
            "currentVersion": "0.1.0",
            "isSingleVersion": true,
            "fixedVersion": "0.1.0"
          }
        ],
        "packageFile": "Dockerfile"
      }
    ],
    "helmfile": [
      {
        "deps": [
          {
            "depName": "test-chart",
            "currentValue": "0.1.0",
            "registryUrls": [
              "docker.io/replaceme"
            ],
            "datasource": "docker",
            "packageName": "docker.io/replaceme/test-chart",
            "updates": [],
            "versioning": "docker",
            "warnings": [
              {
                "topic": "docker.io/replaceme/test-chart",
                "message": "Failed to look up docker package docker.io/replaceme/test-chart"
              }
            ]
          }
        ],
        "datasource": "helm",
        "packageFile": "helmfile.yaml"
      }
    ],
    "helmv3": [
      {
        "deps": [
          {
            "depName": "test-chart",
            "currentValue": "0.1.0",
            "datasource": "docker",
            "packageName": "docker.io/replaceme/test-chart",
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "0.2.0",
                "newValue": "0.2.0",
                "newMajor": 0,
                "newMinor": 2,
                "updateType": "minor",
                "branchName": "renovate/test-chart-0.x"
              }
            ],
            "versioning": "docker",
            "warnings": [],
            "registryUrl": "https://index.docker.io",
            "currentVersion": "0.1.0",
            "isSingleVersion": true,
            "fixedVersion": "0.1.0"
          }
        ],
        "datasource": "helm",
        "packageFileVersion": "0.1.0",
        "packageFile": "Chart.yaml"
      }
    ]
  }
}

But this is closer to the output on helmv3 with remaining spotted difference to be registryUrls

on helmfile

"registryUrls": [
              "docker.io/replaceme"
            ],

vs on helmv3

 "registryUrl": "https://index.docker.io"

And with the following helmfile changes it WORKS 🎉 😅

repositories:

- name: docker.io
  # url: docker.io/replaceme
  url: index.docker.io/replaceme
  oci: true


releases:

- name: test-chart
  namespace: test
  chart: docker.io/test-chart
  version: 0.1.0  

results

{
  "baseBranch": "main"
  "config": {
    "helmfile": [
      {
        "deps": [
          {
            "depName": "test-chart",
            "currentValue": "0.1.0",
            "registryUrls": [
              "index.docker.io/replaceme"
            ],
            "datasource": "docker",
            "packageName": "index.docker.io/replaceme/test-chart",
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "0.2.0",
                "newValue": "0.2.0",
                "newMajor": 0,
                "newMinor": 2,
                "updateType": "minor",
                "branchName": "renovate/test-chart-0.x"
              }
            ],
            "versioning": "docker",
            "warnings": [],
            "registryUrl": "https://index.docker.io",
            "currentVersion": "0.1.0",
            "isSingleVersion": true,
            "fixedVersion": "0.1.0"
          }
        ],
        "datasource": "helm",
        "packageFile": "helmfile.yaml"
      }
    ]
  }
}

it feels a bit convoluted and not so easy to get right but it works. I will just leave it open for now in the attempt to get some feeback on this and how i can get advice to improve setup if possible but i am good to go for now as i get this working.

Have you created a minimal reproduction repository?

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[jduepmeier]

I have the same problem for gitlab projects.
In my repo config i only define the gitlab registry:

repositories:
  - name: gitlab
    url: registry.<domain>
    oci: true

My releases have the full path:

releases:
  - name: chart-1
    chart: gitlab/repo-1/chart-1
  - name: chart-2
    chart: gitlab/repo-2/chart-2

This is not possible because the repo path will be added to the depname instead of the repo (see

renovate/lib/modules/manager/helmfile/extract.ts

Lines 103 to 107 in 51eea2e

	if (dep.chart.includes('/')) {
	const v = dep.chart.split('/');
	repoName = v.shift()!;
	depName = v.join('/');
	} else {

). Then there is a regex check for the depName which fails (see

renovate/lib/modules/manager/helmfile/extract.ts

Line 140 in ad86fc7

if (!isValidChartName(res.depName)) {

)

I think a better way is to split the chart into 3 parts (repoName, repoPath and depName).

[kuzaxak]

Proposed a solution to address an issue in PR