Migrate Config removes comments from JSON5 and overwrites re-adding them

[jpgoelz]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

Renovate keeps removing all comments from our JSON5. I re-added the comments in the same branch but Renovate just force-pushed right back over them.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[rarkins]

This is a documented limitation

[jpgoelz]

True, but my focus was more on the "force-push" over my changes, not on the JSON5. Other Renovate PRs get "locked" if they detect changes by someone else.

However, I think that also answers my question: I amended the reverting changes where I re-added the comments to the Renovate commit. Renovate will probably recognize the commit as its own and just overwrite it.

Thank you for the quick reply!

[jpgoelz]

Confirmed.

[github-actions[bot]]

Hi there,

A maintainer decided this is not a bug, and behaving as designed. The maintainer will explain why this behavior is correct. To avoid confusing future readers, we will close this Discussion.

We want Bug-type Discussions to be about things that we rate as bugs. For more details, please read our development docs about bug handling.

If this bug report makes you think of an idea for a new feature, or how to improve a current feature, feel free to create a new Suggest an Idea Discussion.

Thanks, the Renovate team