CustomManager detects only the last dependency

[P1tt187]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

I am writing a custom manager to watch intellij product releases.

The idea is to get the versions from an api call. this needs the idea productcode
To pass this parameter i tryed to use the packagename

customDatasources: {    
    // product codes # curl -s "https://data.services.jetbrains.com/products?release.type=release"  | jq '.[] | "\(.code) -> \(.name)"'
    jetbrainsProduct: {
      defaultRegistryUrlTemplate: "https://data.services.jetbrains.com/products?code={{packageName}}&release.type=release",
      "transformTemplates": [
        "{\"releases\": $.releases@$release.{ \"version\":$release.version,\"changelogUrl\": $release.notesLink ? $release.notesLink : undefined }, \"homepage\": $.link}"
      ]
    }
  }

To test this i created a yaml file and added an entry for intellij ultimate

# renovate: datasource=custom.jetbrainsProduct depName=IIU versioning=maven
idea_version: "2024.1.4"

Renovate opend a PR to upgrade to 2024.2.1

Now i added another entry

# renovate: datasource=custom.jetbrainsProduct depName=IIU versioning=maven
idea_version: "2024.1.4"

# renovate: datasource=custom.jetbrainsProduct depName=PS versioning=maven
php_storm_version: 2023.1.2

renovate autoclosed the PR for IIU and opend pullrequests for PS

The dependency dashboard only lists PS as dependency.

Did I missconfigured anything or is this a bug?

Repository is available at https://github.com/P1tt187/renovate-idea-custom-manager

Logs (if relevant)

Logs

DEBUG: packageFiles with updates
{
  "baseBranch": "main"
  "config": {
    "regex": [
      {
        "deps": [
          {
            "currentValue": "2024.1.4\"",
            "datasource": "custom.jetbrainsProduct",
            "depName": "IIU",
            "packageName": "IIU",
            "replaceString": "# renovate: datasource=custom.jetbrainsProduct depName=IIU versioning=maven\nidea_version: \"2024.1.4\"",
            "skipReason": "invalid-value",
            "versioning": "maven",
            "warnings": [],
            "updates": []
          },
          {
            "currentValue": "2023.1.2",
            "currentVersion": "2023.1.2",
            "datasource": "custom.jetbrainsProduct",
            "depName": "PS",
            "fixedVersion": "2023.1.2",
            "homepage": "https://www.jetbrains.com/phpstorm",
            "isSingleVersion": true,
            "packageName": "PS",
            "replaceString": "# renovate: datasource=custom.jetbrainsProduct depName=PS versioning=maven\nphp_storm_version: 2023.1.2",
            "versioning": "maven",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "2023.3.7",
                "newValue": "2023.3.7",
                "newMajor": 2023,
                "newMinor": 3,
                "newPatch": 7,
                "updateType": "minor",
                "branchName": "renovate/ps-2023.x"
              },
              {
                "bucket": "major",
                "newVersion": "2024.2.1",
                "newValue": "2024.2.1",
                "newMajor": 2024,
                "newMinor": 2,
                "newPatch": 1,
                "updateType": "major",
                "branchName": "renovate/ps-2024.x"
              }
            ]
          }
        ],
        "matchStrings": [
          "#\\s*renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?\\s.*?_version\\s*:\\s*(\"|')?(?<currentValue>.*)(\"|')?"
        ],
        "packageFile": "versions.yaml",
        "versioningTemplate": "{{#if versioning}}{{{versioning}}}{{/if}}"
      }
    ]
  }
}
DEBUG: Checking packageFiles for deprecated packages
{
  "packageFiles": {
    "regex": [
      {
        "deps": [
          {
            "currentValue": "2024.1.4\"",
            "datasource": "custom.jetbrainsProduct",
            "depName": "IIU",
            "packageName": "IIU",
            "replaceString": "# renovate: datasource=custom.jetbrainsProduct depName=IIU versioning=maven\nidea_version: \"2024.1.4\"",
            "skipReason": "invalid-value",
            "versioning": "maven",
            "warnings": [],
            "updates": []
          },
          {
            "currentValue": "2023.1.2",
            "currentVersion": "2023.1.2",
            "datasource": "custom.jetbrainsProduct",
            "depName": "PS",
            "fixedVersion": "2023.1.2",
            "homepage": "https://www.jetbrains.com/phpstorm",
            "isSingleVersion": true,
            "packageName": "PS",
            "replaceString": "# renovate: datasource=custom.jetbrainsProduct depName=PS versioning=maven\nphp_storm_version: 2023.1.2",
            "versioning": "maven",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "2023.3.7",
                "newValue": "2023.3.7",
                "newMajor": 2023,
                "newMinor": 3,
                "newPatch": 7,
                "updateType": "minor",
                "branchName": "renovate/ps-2023.x"
              },
              {
                "bucket": "major",
                "newVersion": "2024.2.1",
                "newValue": "2024.2.1",
                "newMajor": 2024,
                "newMinor": 2,
                "newPatch": 1,
                "updateType": "major",
                "branchName": "renovate/ps-2024.x"
              }
            ]
          }
        ],
        "matchStrings": [
          "#\\s*renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?\\s.*?_version\\s*:\\s*(\"|')?(?<currentValue>.*)(\"|')?"
        ],
        "packageFile": "versions.yaml",
        "versioningTemplate": "{{#if versioning}}{{{versioning}}}{{/if}}"
      }
    ]
  }
}

[astellingwerf]

I seem to recall that the regex engine sometimes sticks with the largest match. Would you try using [a-z_]+_version or similar instead of .*?_version?

[P1tt187]

looks like you're right, there was a missconfiguration in the yaml pattern

this fixed it for me
#\s*renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?\s[a-z_]+_version\s*:\s*("|')?(?<currentValue>[^"'\s]*)(?:"|')?

thanks for the quick reply