Found errors in presets inside the inherited configuration from v39.63.1

[dw-alexangas]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitHub docker image

Please tell us more about your question or problem

Our last successful Renovate run was v39.62.6. Since we started running v39.63.1 all Renovate runs fail with these error messages:

• Found errors in presets inside the inherited configuration
• matchPackageNames: matchPackageNames should be inside a packageRule only

The stack trace is:

Error: config-validation
    at mergeInheritedConfig (/usr/local/renovate/lib/workers/repository/init/inherited.ts:122:11)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at getRepoConfig (/usr/local/renovate/lib/workers/repository/init/config.ts:12:12)
    at initRepo (/usr/local/renovate/lib/workers/repository/init/index.ts:56:12)
    at Object.renovateRepository (/usr/local/renovate/lib/workers/repository/index.ts:64:14)
    at attributes.repository (/usr/local/renovate/lib/workers/global/index.ts:206:11)
    at start (/usr/local/renovate/lib/workers/global/index.ts:191:7)
    at /usr/local/renovate/lib/renovate.ts:19:22

At a guess this is related to the change in #31642.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[github-actions[bot]]

Hi there,

We need more information about your environment.

Please explain in detail how you are running Renovate. For example:

• Are you running via an official Renovate image, or using the Renovate npm package?
• Which exact image tag are you running?
• Which config/parameters are you using when running the image?
• Which config are you using in your CI/CD pipeline, if relevant?

Thanks, the Renovate team

[dw-alexangas]

We have a centralised renovate-config repo in GitHub. We are running Renovate as a GitHub action. The complete action file is this:

name: Renovate Bot
on:
  workflow_dispatch:
  schedule:
    - cron: '5 * * * *'
jobs:
  run_renovate:
    runs-on: ubuntu-latest
    steps:
    - name: Checkout
      uses: actions/checkout@v4
    - name: Run Renovate Bot
      uses: renovatebot/github-action@v40.2.10
      with:
        token: ${{ secrets.RENOVATE_TOKEN }}
      env:
        RENOVATE_AUTODISCOVER: 'true'
        RENOVATE_INHERIT_CONFIG: 'true'
        RENOVATE_INHERIT_CONFIG_STRICT: 'true'
        # LOG_LEVEL: 'debug'

In that repo we also have default.json:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json"
}

Finally we have org-inherited-config.json which looks like this (some has been trimmed):

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["config:recommended"],
  "baseBranches": ["main", "/^release\\/.*/"],
  "commitMessageSuffix": "AB#0000",
  "configMigration": true,
  "packageRules": [
    {
      "matchUpdateTypes": ["major", "minor"],
      "enabled": false
    },
    {
      "matchDatasources": ["github-releases"],
      "matchPackageNames": ["hashicorp/terraform"],
      "allowedVersions": "=1.9",
      "prBodyNotes": ["BREAKING CHANGE"],
      "semanticCommitType": "fix",
      "extends": [":semanticCommitTypeAll(fix)"],
      "groupName": "terraform-providers",
      "enabled": true
    },
    {
      "matchDatasources": ["terraform-provider"],
      "matchPackageNames": ["hashicorp/azuread"],
      "allowedVersions": "=3.0.2",
      "prBodyNotes": ["BREAKING CHANGE"],
      "semanticCommitType": "fix",
      "extends": [":semanticCommitTypeAll(fix)"],
      "groupName": "terraform-providers",
      "enabled": true
    },
    {
      "matchDatasources": ["terraform-provider"],
      "matchPackageNames": ["hashicorp/azurerm"],
      "allowedVersions": "=4.11.0",
      "prBodyNotes": ["BREAKING CHANGE"],
      "semanticCommitType": "fix",
      "extends": [":semanticCommitTypeAll(fix)"],
      "groupName": "terraform-providers",
      "enabled": true
    },
    {
      "matchDatasources": ["terraform-provider"],
      "matchPackageNames": ["Azure/azapi"],
      "allowedVersions": "=2.0.1",
      "prBodyNotes": ["BREAKING CHANGE"],
      "semanticCommitType": "fix",
      "extends": [":semanticCommitTypeAll(fix)"],
      "groupName": "terraform-providers",
      "enabled": true
    }
  ],
  "reviewersFromCodeOwners": true,
  "schedule": [
    "after 12am every weekday",
    "every weekend"
  ],
  "timezone": "UTC",
  "semanticCommits": "enabled",
  "vulnerabilityAlerts": {
    "schedule": [],
    "rangeStrategy": "update-lockfile",
    "commitMessageSuffix": "AB#0000 [SECURITY]",
    "branchTopic": "{{{datasource}}}-{{{depName}}}-vulnerability",
    "prCreation": "immediate",
    "packageRules": [
      {
        "matchUpdateTypes": ["minor"],
        "enabled": true
      }
    ]
  },
  "customManagers": [
    {
      "customType": "regex",
      "fileMatch": ["^\\.github/workflows/[^/]+\\.ya?ml$"],
      "matchStrings": ["\\snpx semantic-release@(?<currentValue>.*?)\\s"],
      "datasourceTemplate": "npm",
      "depNameTemplate": "semantic-release"
    },
    {
      "customType": "regex",
      "fileMatch": ["^\\.github/workflows/[^/]+\\.ya?ml$"],
      "matchStrings": ["\\snpm install -D conventional-changelog-conventionalcommits@(?<currentValue>.*?)\\s"],
      "datasourceTemplate": "npm",
      "depNameTemplate": "conventional-changelog-conventionalcommits"
    },
    {
      "customType": "regex",
      "fileMatch": ["^\\.tflint\\.hcl$"],
      "matchStrings": ["\\s+version\\s*=\\s*\"(?<currentValue>[0-9\\.]+)\".*\\n\\s+source\\s*=\\s*\"github.com/terraform-linters/tflint-ruleset-terraform\""],
      "datasourceTemplate": "github-releases",
      "depNameTemplate": "terraform-linters/tflint-ruleset-terraform",
      "extractVersionTemplate": "^v(?<version>.+)$"
    },
    {
      "customType": "regex",
      "fileMatch": ["^\\.tflint\\.hcl$"],
      "matchStrings": ["\\s+version\\s*=\\s*\"(?<currentValue>[0-9\\.]+)\".*\\n\\s+source\\s*=\\s*\"github.com/terraform-linters/tflint-ruleset-azurerm\""],
      "datasourceTemplate": "github-releases",
      "depNameTemplate": "terraform-linters/tflint-ruleset-azurerm",
      "extractVersionTemplate": "^v(?<version>.+)$"
    }
  ]
}

Then in a code repo we have renovate.json:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "local>ourorgname/renovate-config"
  ]
}

[rarkins]

Thanks, I was able to reproduce it enough to be able to debug. It was a strange root cause, should be fixed in #33088