Getting patterns.filter is not a function error

[JanMalte]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab self-hosted 17.7.0

Please tell us more about your question or problem

When running the periodic renovate run, I'm getting the error patterns.filter is not a function.

It seems only repositories with some package rules are affected.

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["local>gegl-group/renovate-config"],
  "baseBranches": ["develop"],
  "packageRules": [
    {
      "description": "disable major updates for fontawesome and bootstrap",
      "matchDepNames": ["@fortawesome/fontawesome-free", "bootstrap"],
      "matchUpdateTypes": "major",
      "matchManagers": ["npm"],
      "enabled": false
    }
  ]
}

Logs (if relevant)

Logs

INFO: Repository started (repository=********)
       "renovateVersion": "39.82.9"
 INFO: Dependency extraction complete (repository=********, baseBranch=develop)
       "stats": {
         "managers": {
           "gitlabci": {"fileCount": 1, "depCount": 6},
           "npm": {"fileCount": 1, "depCount": 20},
           "nvm": {"fileCount": 1, "depCount": 1},
           "pep621": {"fileCount": 1, "depCount": 1},
           "poetry": {"fileCount": 1, "depCount": 24},
           "pre-commit": {"fileCount": 1, "depCount": 6},
           "pyenv": {"fileCount": 1, "depCount": 1},
           "regex": {"fileCount": 2, "depCount": 2}
         },
         "total": {"fileCount": 9, "depCount": 61}
       }
ERROR: lookupUpdates error (repository=********, baseBranch=develop, packageFile=package.json)
        {
           "name": "renovate",
           "level": 50,
           "logContext": "********",
           "repository": "********",
           "baseBranch": "develop",
           "currentValue": "4.6.2",
           "datasource": "npm",
           "packageName": "bootstrap",
           "followTag": null,
           "lockedVersion": "4.6.2",
           "packageFile": "package.json",
           "pinDigests": false,
           "rollbackPrs": false,
           "isVulnerabilityAlert": true,
           "updatePinnedDependencies": true,
           "err": {
             "message": "patterns.filter is not a function",
             "stack": "TypeError: patterns.filter is not a function\n    at matchRegexOrGlobList (/usr/local/renovate/lib/util/string-match.ts:38:37)\n    at /usr/local/renovate/lib/util/string-match.ts:66:33\n    at Array.some (<anonymous>)\n    at anyMatchRegexOrGlobList (/usr/local/renovate/lib/util/string-match.ts:66:17)\n    at UpdateTypesMatcher.matches (/usr/local/renovate/lib/util/package-rules/update-types.ts:21:35)\n    at matchesRule (/usr/local/renovate/lib/util/package-rules/index.ts:15:35)\n    at applyPackageRules (/usr/local/renovate/lib/util/package-rules/index.ts:42:9)\n    at filterInternalChecks (/usr/local/renovate/lib/workers/repository/process/lookup/filter-checks.ts:56:23)\n    at lookupUpdates (/usr/local/renovate/lib/workers/repository/process/lookup/index.ts:465:11)\n    at /usr/local/renovate/lib/workers/repository/process/fetch.ts:79:12\n    at Function.wrap (/usr/local/renovate/lib/util/stats.ts:38:20)\n    at /usr/local/renovate/lib/workers/repository/process/fetch.ts:125:23\n    at /usr/local/renovate/node_modules/.pnpm/p-map@4.0.0/node_modules/p-map/index.js:57:22"
           }
 INFO: Repository finished (repository=********)
       "cloned": true,
       "durationMs": 56976

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[rarkins]

Debug logs might help pinpoint the problem. If not then a reproduction repo.

[rarkins]

@RahulGautamSingh can you work out why it wasn't migrated?

[JanMalte]

it's probably the matchUpdateTypes option, which should be array instead of string.

we've probably a missing migration or validation.

Thank you very much.

Seems like this was causing the error.
Updating the config in the repositories fixed the failing pipelines.

[RahulGautamSingh]

it's probably the matchUpdateTypes option, which should be array instead of string.

We allow string in the matchUpdateTypes field.

@RahulGautamSingh can you work out why it wasn't migrated?

And, we massage from string -> array, too.

It's confusing how changing from string->array fixed the issue since we already do that anyways.
I tried to reproduce but failed 1 , 2

@JanMalte Could you create one repro? And paste the full logs to be sure

[JanMalte]

@RahulGautamSingh I tried to create a repo, but couldn't. Any new repo is not failing, existing ones fail until the config is fixed.
For the existing repos there have been updates for the dependency in the past. Maybe the lookup for closed/existing MRs is causing migration issues?!

[RahulGautamSingh]

Cannot say for sure without a repro. It is not the migration though.