Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade #1

Open
Naliwe opened this issue Jan 21, 2019 · 2 comments
Open

Upgrade #1

Naliwe opened this issue Jan 21, 2019 · 2 comments

Comments

@Naliwe
Copy link

Naliwe commented Jan 21, 2019

Hello :)

Your wrapper looks really good, but it's apparently too old now :/
So I pulled the project locally, changed a bunch of versions and refactored what changed and it seems to work (on the very little test I made).

Do you want me to pull-request it ? Or have you abandoned development ? In which case I'll just use that local version if that's ok with you; I'm just using a slightly modified version of the jar.

Thanks for your time!

@rivasdiaz
Copy link
Owner

If you send me a pull request I'll review and merge it. I'm happy to also point to your repo on my readme as I have no plans for keep working on this project for now.

@francos
Copy link

francos commented Mar 18, 2020

Hi @Naliwe, was the PR created or did you keep this only in your fork only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants