-
Notifications
You must be signed in to change notification settings - Fork 1.1k
quality of haad's fork, or "reasons for the split"
SOME WORDS ABOUT THE RIVALING FORK ON GITHUB
note that there is another, technically inferior fork of proxychains on github, and its maintainer (haad) unfortunately doesnt seem to have a clue.
his way to deal with problems is to try a lot of different things until it appears to work, and then commits everything he changed, not the one fix that actually made it work. this applies for example to the things he did in order to make proxychains compile on MacOS X. due to this you cannot compile his fork on MacOS X on powerpc, because he added x86-specific CFLAGS: https://github.com/haad/proxychains/commit/2250ef66a8a231da603ba60d8e61ddadcf8d863e
he also adds non-portable headers such as sys/cdefs.h without any actual reason, and then blatantly claims that this is POSIX compliant, however the POSIX spec doesnt say a single word about that header. it is a completely non-standard glibc specific header. https://github.com/haad/proxychains/commit/361889a2d29414a0277bc2f606e29d9a2067066a#L2R18
thus, his commit history is full of bugs, commits that dont even compile or checked in binaries.
his fork is a couple of months older than mine.
he basically forked proxychains 3.1 and applied 3 or 4 patches floating around on the sf.net forums. that's about anything that he has achieved. when i came, i forked his instead of starting from scratch, and in the beginning i collaborated with him (any changes that add actual value are written by me) and opened pull requests for my work. i quickly became annoyed by his clueless and careless commits, and decided to continue on my own.
meanwhile, his fork has gotten totally irrelevant and unmaintained, apart from the occassional automatic pull request. (i have the impression he doesn't even review them and just clicks on merge whenever a new PR pops up)
here's haad's history of fail:
https://github.com/haad/proxychains/commit/1c020ced1e97c697d6c927da0c0076835cb932b6 https://github.com/haad/proxychains/commit/361889a2d29414a0277bc2f606e29d9a2067066a https://github.com/haad/proxychains/commit/462e34f447447b95a6459771ca1b21e200c22f4a https://github.com/haad/proxychains/commit/c1f0c68abd197a9a0e8b3cd7bcab97ca410aa575 https://github.com/haad/proxychains/commit/adb13c7e79ef85d0c7614687603c57a709b4094d https://github.com/haad/proxychains/commit/f512779539f20d6cc2a9ade700ddb70105f3d5b5#L2R481 https://github.com/haad/proxychains/commit/865dc76c0805538356045cfd2e009ad75c4d250a https://github.com/haad/proxychains/commit/5b7270d75b181cd0fb59e4e6983ec606e48c275a https://github.com/haad/proxychains/commit/efa5738a6a579c60e3f4f7f544eba0f0b1442999 https://github.com/haad/proxychains/commit/14e15aa2c179116d9be90ffadcd42b0035215661