Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev version of shiny.scss errors out with CRAN version of bslib #3922

Closed
cpsievert opened this issue Oct 25, 2023 · 0 comments · Fixed by #3924
Closed

Dev version of shiny.scss errors out with CRAN version of bslib #3922

cpsievert opened this issue Oct 25, 2023 · 0 comments · Fixed by #3924
Assignees
@gadenbuie

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Oct 25, 2023 •
edited
Loading

Introduced by #3914 (which is assuming Bootstrap Sass variables introduced in Bootstrap 5.3 exist)

remotes::install_version("bslib", "0.5.1")
remotes::install_github("rstudio/shiny")
shiny::shinyApp(bslib::page_fluid(), \(...) {})
Error: Undefined variable: "$body-emphasis-color". on line 14:115 of ../../R/4.2/shiny/www/shared/shiny_scss/shiny.bootstrap5.scss from line 15:9 of stdin >> $notification-color: var(--#{$prefix}emphasis-color, #{$body- ------------------------------------------------------------------------------------------------------------------^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gadenbuie gadenbuie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shiny.scss): Ensure $body-emphasis-color is defined for all BS5 rstudio/shiny
2 participants
@cpsievert @gadenbuie