Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message text color is too subtle with Bootstrap 5 #4000

Closed
cpsievert opened this issue Mar 19, 2024 · 0 comments · Fixed by #4001
Closed

Error message text color is too subtle with Bootstrap 5 #4000

cpsievert opened this issue Mar 19, 2024 · 0 comments · Fixed by #4001
Milestone

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Mar 19, 2024

In #3914, the text color of error messages changed from red to --bs-danger-text-emphasis, which I think was designed to be put on a danger bg, and IMO is too close to black for error messages. Perhaps --bs-danger would be better @gadenbuie?

library(shiny)
library(bslib)

ui <- page_fixed(
  textOutput("foo")
)

server <- function(input, output, session) {
  output$foo <- renderText({1+"a"})
}

shinyApp(ui, server)
Screenshot 2024-03-19 at 5 29 40 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant