Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "deposit" to "topUp" #344

Open
PaulRBerg opened this issue Dec 4, 2024 · 2 comments
Open

Rename "deposit" to "topUp" #344

PaulRBerg opened this issue Dec 4, 2024 · 2 comments
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

Rationale:

  • It's a more specific and more accurate name for this functionality — since it reflects the continues nature of the Flow stream
  • Differentiate Flow from Lockup/ Airdrops
@PaulRBerg PaulRBerg added type: refactor Change that neither fixes a bug nor adds a feature. effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Dec 4, 2024
@smol-ninja
Copy link
Member

Is it just for the function name or do you mean to refer to top up instead of deposit everywhere? If its latter, I'd mark it as effort: medium or mb high.

@PaulRBerg PaulRBerg added effort: high Large or difficult task. and removed effort: low Easy or tiny task that takes less than a day. labels Dec 9, 2024
@PaulRBerg
Copy link
Member Author

The latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @PaulRBerg