Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shapeless with magnolia in (semi?)auto #16

Open
MateuszKubuszok opened this issue Aug 19, 2019 · 2 comments
Open

Replace shapeless with magnolia in (semi?)auto #16

MateuszKubuszok opened this issue Aug 19, 2019 · 2 comments
Labels
good first issue

Comments

@MateuszKubuszok
Copy link
Member

No description provided.

@pk044
Copy link

pk044 commented Sep 10, 2019

the tests for your implementation in the magnolia-impl branch you made seem to pass after updating Magnolia to the newest version.

Shapeless is not removed though, so I could do it and make a pull request in the evening, unless you perhaps would like some more changes to be done? :)

@MateuszKubuszok
Copy link
Member Author

I believe shapeless can be removed if magnolia works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MateuszKubuszok @pk044