Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass column names to :fastmath/ols models #24

Open
daslu opened this issue Oct 23, 2024 · 5 comments
Open

pass column names to :fastmath/ols models #24

daslu opened this issue Oct 23, 2024 · 5 comments
Assignees

Comments

@daslu
Copy link
Member

daslu commented Oct 23, 2024

fastmath.ml.regression/lm supports a :names option that controls the names of the coefficients when the model is printed.
https://generateme.github.io/fastmath/clay/ml.html#lm

In the metamorph.ml context, our data originate from a dataset, so we may use the column names for that.

@behrica
Copy link
Member

behrica commented Nov 17, 2024

@daslu
did you mention this as one of the changes you wanted to do, if /when we would add the model to tablecloth itself ?

(which I am not sure, we should do, as the model is available here)

@daslu
Copy link
Member Author

daslu commented Dec 4, 2024

Sorry for missing this message earlier.

Yes, I think we should have a Tablecloth function to take care of that eventually.

@behrica
Copy link
Member

behrica commented Dec 4, 2024

are you refering to pass :names as written here:
https://generateme.github.io/fastmath/clay/ml.html#lm

If so, then fixing #27 will fix this as well.

@daslu
Copy link
Member Author

daslu commented Dec 4, 2024

Yes

@daslu
Copy link
Member Author

daslu commented Dec 4, 2024

Yes, but I am proposing this will happen automatically -- the dataset column names will be passed as :names by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants