Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Trial/extra trial data instance creation #468

Open
katconnors opened this issue Nov 19, 2024 · 0 comments · May be fixed by #484
Open

Incorrect Trial/extra trial data instance creation #468

katconnors opened this issue Nov 19, 2024 · 0 comments · May be fixed by #484
Assignees
@katconnors
Labels
bug Something isn't working

Comments

@katconnors
Copy link
Contributor

katconnors commented Nov 19, 2024 •
edited
Loading

When a user navigates directly to a new benchmark (without trial data) via the url benchmarks/[id]/instructions url and then clicks "collect data", trial 2 is sometimes displayed instead of trial 1.

Further insight: I monitored the table "trial_data", and after clicking collect data (at the above url), two trial data instances are created.

See benchmark-instructions branch for some comments on behavior (f289283)

image
image
@katconnors katconnors added the bug Something isn't working label Nov 19, 2024
@katconnors katconnors mentioned this issue Nov 19, 2024
Open
@katconnors katconnors moved this to Ready for Dev in Compass Nov 19, 2024
@katconnors katconnors self-assigned this Nov 20, 2024
@katconnors katconnors mentioned this issue Dec 11, 2024
Open
@katconnors katconnors linked a pull request Dec 21, 2024 that will close this issue
Open
@katconnors katconnors moved this from Ready for Dev to In Development in Compass Dec 21, 2024
@katconnors katconnors moved this from In Development to Engineering Code Review in Compass Dec 21, 2024
@katconnors katconnors linked a pull request Dec 21, 2024 that will close this issue
Fixes #468 (extra trial data) - update to prevent rerender #484
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katconnors katconnors

Labels
bug Something isn't working
Projects
Compass
Status: Engineering Code Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #468 (extra trial data) - update to prevent rerender sfbrigade/compass
1 participant
@katconnors