Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change keyword that server checks for a Tester user #234

Open
francisli opened this issue Jul 18, 2024 · 3 comments · Fixed by #235
Open

Change keyword that server checks for a Tester user #234

francisli opened this issue Jul 18, 2024 · 3 comments · Fixed by #235
Assignees
@JimmiHagen

Comments

@francisli
Copy link
Collaborator

We used to have some code that checked if the first or last name of a user was "Tester" to mark a user as a tester that is excluded from contest data analysis.

Let's try changing it to:

  • IWT (not case sensitive)
@JimmiHagen JimmiHagen self-assigned this Jul 18, 2024
@JimmiHagen
Copy link
Collaborator

change will likely be line 22 of appuser.py

@JimmiHagen JimmiHagen linked a pull request Jul 30, 2024 that will close this issue
basic search/replace of Tester with iwt, including schema doc #235
Merged
JimmiHagen pushed a commit that referenced this issue Aug 8, 2024
#234 simplify prefixes list to just "iwt", document case insensitivity
1a5dbf4
francisli pushed a commit that referenced this issue Aug 8, 2024
@JimmiHagen
[Closes #234] Basic search/replace of Tester with iwt, including sche…
76f6463 
…ma doc (#235)

* basic search/replace of Tester with iwt, including schema doc

* 234 Black formatting for test_appuser.py

* #234 simplify prefixes list to just "iwt", document case insensitivity

---------

Co-authored-by: Jimmi <jimmih@gmail.com>
@francisli francisli reopened this Aug 8, 2024
@francisli
Copy link
Collaborator Author

Reopening because the test actually failed, but we didn't notice because of #236

@JimmiHagen
Copy link
Collaborator

The test should actually fail, though it seems a bit odd for the behavior to be as it is - if the user name is just "iwt", that somehow fails the "is prefix" test, which is how the test worked previously for "tester"... which again, seems not quite right.

The first step is to make CircleCI complain about the failed test as it should, though, so this is somewhat blocked by #236

JimmiHagen pushed a commit that referenced this issue Sep 12, 2024
#234 actually fixing the "iwt-d" test, this time
e64a3bb
JimmiHagen pushed a commit that referenced this issue Sep 12, 2024
#234 changed is_tester logic to tokenize and check for 'iwt' regardle…
fa617a6 
…ss of case
francisli added a commit that referenced this issue Sep 12, 2024
@JimmiHagen @francisli
[#234] Change keyword that server checks for a tester user (#244)
a9bdf3d 
* basic search/replace of Tester with iwt, including schema doc

* 234 Black formatting for test_appuser.py

* #234 simplify prefixes list to just "iwt", document case insensitivity

* #234 actually fixing the "iwt-d" test, this time

* #234 changed is_tester logic to tokenize and check for 'iwt' regardless of case

* Add one more test

* Remove unused var

---------

Co-authored-by: Jimmi <jimmih@gmail.com>
Co-authored-by: Francis Li <mail@francisli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimmiHagen JimmiHagen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

basic search/replace of Tester with iwt, including schema doc sfbrigade/intentional-walk-server
2 participants
@francisli @JimmiHagen