Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other issue]: File following list of issues (chore) #266

Open
1 of 7 tasks
nickvisut opened this issue Oct 31, 2024 · 0 comments
Open
1 of 7 tasks

[Other issue]: File following list of issues (chore) #266

nickvisut opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels

Comments

@nickvisut
Copy link
Collaborator

nickvisut commented Oct 31, 2024

What is the issue you are reporting?

Pasted from Slack (and modified a bit), each of these ought to be filed as an issue (if still relevant). To be clear, this is a chore to enter the below list as individual issues.


putting a coupla bugs here for now to be added to GitHub later:

  • the placeholder school card no longer shows up on mobile
  • hard to click/select school adjacent to already selected school (Ruth Asawa vs The Academy) even when mostly zoomed in
  • active (yellow) map marker appears on top of map controls (zoom buttons, for instance)
  • console warning about the embedded element on map load
hook.js:591 Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>. Error Component Stack
    at a (<anonymous>)
    at LinkComponent (link.js:105:19)
    at div (<anonymous>)
    at div (<anonymous>)
    at SchoolCard (SchoolCardMap.tsx:38:3)
    at SelectedSchoolCard (map.tsx:81:21)
    at a (<anonymous>)
    at LinkComponent (link.js:105:19)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at Map (map.tsx:40:87)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at RootLayout (RootLayout.tsx:12:23)
    at MapProvider (MapContext.tsx:27:72)
    at Provider (Provider.js:13:3)
    at MyApp (_app.tsx:17:18)
    at PathnameContextProviderAdapter (adapters.js:80:11)
    at ErrorBoundary (client.js:306:63)
    at ReactDevOverlay (client.js:858:919)
    at Container (index.js:78:1)
    at AppContainer (index.js:182:11)
    at Root (index.js:372:11)
  • marker not necessarily “off the view screen” but will act as being off screen and pan, and the opposite (likely due to map marker “tip” not aligning with lat/long, but instead the marker “center”)
  • look into asking for geolocation behavior; is it asking for it too often/aggressively? seems to throw an issue, in any case (more of a potential UX thing if it's an actual issue)

less a user-facing issue, more a potential blocker:

  • why is DOM topmost element not behaving as expected? (to fix “hidden under school card” issue)

Contact Details

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants