Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly apply comments for JSX #10

Open
silvenon opened this issue Jan 29, 2019 · 1 comment
Open

Correctly apply comments for JSX #10

silvenon opened this issue Jan 29, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@silvenon
Copy link
Owner

When commenting a line using + /, top-level JSX:

<Foo />

should turn into Markdown comments:

<!-- <Foo /> -->

and commenting content inside a JSX tag:

<Foo>
  <Bar />
</Foo>

should turn into JSX comments:

<Foo>
  {/* <Bar /> */}
</Foo>
@silvenon silvenon added the bug Something isn't working label Jan 29, 2019
@silvenon
Copy link
Owner Author

silvenon commented Jan 22, 2020

The latter case works now, but the first case still doesn't, and it's very tricky because it's JSX until it's commented, then it becomes treated as Markdown. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant