DX: Options is getter/setter

[ducan-ne]

Currently, the options have getter and setter, which is quite unnatural when add option. See below images for more details

The definition of got

When we use it with IDE

Press enter

Should I create an issue for this?

[szmarczak]

I'm assuming you want to add your own option? Currently it's not possible like that. Use options.context instead.

[ducan-ne]

@szmarczak no I mean the current options interface is quite weird, it's hard when I use for development, so I put in the title it related to developer experience (DX), please take a look at the picture
For example I want to add timeout option to my request, but the auto complete show me "get timeout() {}", it's weird
https://github.com/sindresorhus/got/blob/main/source/core/options.ts#L1196
I more prefer options just like this

interface/class Options {
	timeout: number
}

[szmarczak]

It must be your IDE. I don't have any issues with vscode.

[ducan-ne]

Yeah but it's unatural when our project have setter and getter.
Btw I have no idea to fix this technically, thinking about use older version, thx 🙏

[szmarczak]

Yeah but it's unatural when our project have setter and getter.

Many other libraries use getters/setters, for example node-fetch it's very natural thing.