Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate responsibility of FileAirfoil to adhere to SRP #6

Open
skilkis opened this issue Aug 9, 2020 · 0 comments
Open

Separate responsibility of FileAirfoil to adhere to SRP #6

skilkis opened this issue Aug 9, 2020 · 0 comments
Assignees
@skilkis
Labels
feature New feature or request

Comments

@skilkis
Copy link
Owner

skilkis commented Aug 9, 2020

The Single Responsibility Principle (SRP) is violated by the FileAirfoil class as it has the functionality to read points from a file as well as to generate an airfoil from a list of points. These should ideally be two different classes.
@skilkis skilkis added the feature New feature or request label Aug 9, 2020
@skilkis skilkis self-assigned this Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skilkis skilkis

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skilkis