-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Provide more details to Users when Quality Checks are not met #122
Comments
Thoughts on what to include in the details? The implementation might dictation the "details of the details", but do we link back to comments that we would have just posted to the PR, and/or add a boiler plate note to see above comments and a link back to general docs?...just thinking out load about in the weeds "details about details".... ;) |
I think this will require quite a bit more thought and fleshing out @bhamail before we commit to actioning anything... |
I was thinking something similar to this PR (cyclonedx also require all commits to be signed). Also the help doc is great for setting up your commits to be signed, but it isn't too helpful if you already have unsigned commits. How do you rectify that? Rebasing? |
Thanks for the comments @shaikhu - we will open a ticket to improve the docs re your last point. |
Feedback from @shaikhu re. sonatype-nexus-community/scan-gradle-plugin#165
"Just a suggestion. It would be helpful to have a "Details" link next to the check (like the other checks) so we can click on it for more information."
FYI @bhamail
The text was updated successfully, but these errors were encountered: