Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Provide more details to Users when Quality Checks are not met #122

Open
madpah opened this issue Oct 1, 2024 · 5 comments
Open

FEAT: Provide more details to Users when Quality Checks are not met #122

madpah opened this issue Oct 1, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@madpah
Copy link
Contributor

madpah commented Oct 1, 2024

Feedback from @shaikhu re. sonatype-nexus-community/scan-gradle-plugin#165

"Just a suggestion. It would be helpful to have a "Details" link next to the check (like the other checks) so we can click on it for more information."

image

FYI @bhamail

@madpah madpah added the enhancement New feature or request label Oct 1, 2024
@bhamail
Copy link
Contributor

bhamail commented Oct 1, 2024

Thoughts on what to include in the details? The implementation might dictation the "details of the details", but do we link back to comments that we would have just posted to the PR, and/or add a boiler plate note to see above comments and a link back to general docs?...just thinking out load about in the weeds "details about details".... ;)

@madpah
Copy link
Contributor Author

madpah commented Oct 4, 2024

I think this will require quite a bit more thought and fleshing out @bhamail before we commit to actioning anything...

@shaikhu
Copy link

shaikhu commented Oct 4, 2024

Thoughts on what to include in the details?

I was thinking something similar to this PR (cyclonedx also require all commits to be signed).
image

Also the help doc is great for setting up your commits to be signed, but it isn't too helpful if you already have unsigned commits. How do you rectify that? Rebasing?

@madpah
Copy link
Contributor Author

madpah commented Oct 4, 2024

Thanks for the comments @shaikhu - we will open a ticket to improve the docs re your last point.

@madpah
Copy link
Contributor Author

madpah commented Oct 4, 2024

Opened sonatype-nexus-community/contribute.sonatype.com#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants