Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger is inaccurate leading to 404s #2

Open
CyborgEric opened this issue Dec 26, 2019 · 4 comments
Open

Swagger is inaccurate leading to 404s #2

CyborgEric opened this issue Dec 26, 2019 · 4 comments

Comments

@CyborgEric
Copy link

When hitting endpoint /ledControl/setAllLedColor and a few other color related endpoints, my route 404s. Would appreciate advice in resolving this as I would like to have LED control over the RVR.
@CyborgEric
Copy link
Author

Tried updating firmware, as well as regenerating node_modules.

@CyborgEric
Copy link
Author

Single led is working. Found some routes in Swagger are incorrect, need to take a pass at that.

@CyborgEric CyborgEric changed the title Endpoint /ledControl/setAllLedColor 404s Swagger is inaccurate leading to 404s Dec 27, 2019
@CyborgEric
Copy link
Author

Found inaccuracies across the swagger page, recommend updating swagger.json. Will make changes with a PR once I learn the codebase a little better.

@meganrobinson22
Copy link
Contributor

meganrobinson22 commented Jan 8, 2020 •
edited
Loading

Hey Eric,

We've pushed some changes for the inaccuracies we found in our swagger.json files, please let us know if you see anything else that we might have missed!

Thanks for bringing these issues to our attention :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CyborgEric @meganrobinson22