This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Support OpenSSL FIPS-140 mode by replacing MD5 with SHA256 #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using esm with NodeJS 9.11 compiled against OpenSSL FIPS-140 Module causes this error:
This can be fixed by using SHA256 instead of MD5 per the OpenSSL FIPS Object Module User Guide:
Adding FIPS support will allow US government organizations to easily use esm in their node servers.
It is expected that this will cause some performance regression but I'm unclear on whether it will be a noticable difference or not.
For reference regarding the performance question here are some benchmark numbers on sha256 vs md5 in nodejs: https://github.com/hex7c0/nodejs-hash-performance