From b300b58f1114ff8c374da136c532a33307940cc0 Mon Sep 17 00:00:00 2001
From: Peter Nied <petern@amazon.com>
Date: Mon, 31 Oct 2022 10:44:28 -0500
Subject: [PATCH] Add CI for Windows and MacOS platforms (#2190) (#2205)

Add CI for Windows and MacOS platforms

Due to the increase in the number of platforms, I've separated the newer integration tests into their own workflow.  Until retries have been enabled they will automatically pass - but still run and report logs.  As soon as we have full confidence we will allow them to start blocking pull requests from merging.  https://github.com/opensearch-project/security/issues/2184

Switch the gradle commands to be platform agnostic via the `gradle/gradle-build-action@v2`, dropping the 'clean' step to the build which allows us to reuse the gradle cache - if we see any problems pulling in more recent snapshots we can disable this setting quickly.

Found and fixed an issued with config value replacement via environment variables, long story short Windows and MacOS allow for many more characters that are used in the unix environment variable landscape.  Added new tests to cover these interesting scenarios as well.

Found an encoding issue with user names from config files, still unclear of the source of this issue, be it test setup specific or a problem in the broader OpenSearch ecosystem, disabling the `testSpecialUsernames` until we can dive deeper. https://github.com/opensearch-project/security/issues/2194

Disabled the HeapBasedRateTrackerTests - it was depending on system timing and was very brittle if the system under test experienced any undo load, created follow up issue https://github.com/opensearch-project/security/issues/2193

Fixed a test issue in testDlsWithMinDocCountZeroAggregations where there was a random chance for a test failure, easier to find intermittent tests when they are run so often.

OpenSSL has open questions - while it is supported for our Linux JDK11 builds, it seems like a stopgap measure.  I've disabled the tests on windows environment while we determine if we should support OpenSSL at all on Windows JDK11.  https://github.com/opensearch-project/security/issues/2195

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit a57fd0a745a398b1fb7ba005bda44d0e55f5fc88)
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
---
 .github/workflows/ci.yml                      | 32 -------------------
 .../opensearch/security/IntegrationTests.java |  2 ++
 2 files changed, 2 insertions(+), 32 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ff56351268..bc0659564e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -30,11 +30,9 @@ jobs:
       with:
         arguments: |
           build test -Dbuild.snapshot=false
-          -x integrationTest
           -x spotlessCheck
           -x checkstyleMain
           -x checkstyleTest
-          -x spotbugsMain
 
     - name: Coverage
       uses: codecov/codecov-action@v1
@@ -53,36 +51,6 @@ jobs:
       if: always()
       run: echo "Check the artifact ${{ matrix.platform }}-JDK${{ matrix.jdk }}-reports for detailed test results"
 
-  integration-tests:
-    name: integration-tests
-    strategy:
-      fail-fast: false
-      matrix:
-        jdk: [17]
-        platform: ["ubuntu-latest", "windows-latest", "macos-latest"]
-    runs-on: ${{ matrix.platform }}
-
-    steps:
-    - name: Set up JDK for build and test
-      uses: actions/setup-java@v2
-      with:
-        distribution: temurin # Temurin is a distribution of adoptium
-        java-version: ${{ matrix.jdk }}
-
-    - name: Checkout security
-      uses: actions/checkout@v2
-
-    - name: Build and Test
-      uses: gradle/gradle-build-action@v2
-      continue-on-error: true # Until retries are enable do not fail the workflow https://github.com/opensearch-project/security/issues/2184
-      with:
-        arguments: |
-          integrationTest -Dbuild.snapshot=false
-          -x spotlessCheck
-          -x checkstyleMain
-          -x checkstyleTest
-          -x spotbugsMain
-
   backward-compatibility:
     runs-on: ubuntu-latest
     steps:
diff --git a/src/test/java/org/opensearch/security/IntegrationTests.java b/src/test/java/org/opensearch/security/IntegrationTests.java
index 226551a5ae..246fca03d9 100644
--- a/src/test/java/org/opensearch/security/IntegrationTests.java
+++ b/src/test/java/org/opensearch/security/IntegrationTests.java
@@ -34,6 +34,7 @@
 import org.apache.hc.core5.http.message.BasicHeader;
 import org.junit.Assert;
 import org.junit.Assume;
+import org.junit.Ignore;
 import org.junit.Test;
 
 import org.opensearch.action.admin.indices.alias.IndicesAliasesRequest;
@@ -269,6 +270,7 @@ public void testSingle() throws Exception {
     }
 
     @Test
+    @Ignore // https://github.com/opensearch-project/security/issues/2194
     public void testSpecialUsernames() throws Exception {
     
         setup();