From de7103e2f9f2b84a0ed29f9263dbd64ed01382d8 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Jadda <17564080+pavankjadda@users.noreply.github.com> Date: Mon, 25 Oct 2021 23:53:59 -0400 Subject: [PATCH 1/4] fix(format): reformats project with prettier --- projects/ngx-cookie-service/src/lib/cookie.service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/ngx-cookie-service/src/lib/cookie.service.ts b/projects/ngx-cookie-service/src/lib/cookie.service.ts index 1a8fa6c..31d15bf 100644 --- a/projects/ngx-cookie-service/src/lib/cookie.service.ts +++ b/projects/ngx-cookie-service/src/lib/cookie.service.ts @@ -163,7 +163,7 @@ export class CookieService { domain?: string; secure?: boolean; sameSite?: 'Lax' | 'None' | 'Strict'; - }, + } ): void; set( @@ -218,7 +218,7 @@ export class CookieService { options.secure = true; console.warn( `[ngx-cookie-service] Cookie ${name} was forced with secure flag because sameSite=None.` + - `More details : https://github.com/stevermeister/ngx-cookie-service/issues/86#issuecomment-597720130`, + `More details : https://github.com/stevermeister/ngx-cookie-service/issues/86#issuecomment-597720130` ); } if (options.secure) { From ffdcb1980cb71bf9356410c4bbba1c847e1114da Mon Sep 17 00:00:00 2001 From: Pavan Kumar Jadda <17564080+pavankjadda@users.noreply.github.com> Date: Mon, 25 Oct 2021 23:57:32 -0400 Subject: [PATCH 2/4] fix(format): reformats project with prettier --- projects/ngx-cookie-service/src/lib/cookie.service.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/projects/ngx-cookie-service/src/lib/cookie.service.ts b/projects/ngx-cookie-service/src/lib/cookie.service.ts index 31d15bf..7bf9570 100644 --- a/projects/ngx-cookie-service/src/lib/cookie.service.ts +++ b/projects/ngx-cookie-service/src/lib/cookie.service.ts @@ -14,7 +14,7 @@ export class CookieService { constructor( @Inject(DOCUMENT) private document: any, // Get the `PLATFORM_ID` so we can check if we're in a browser. - @Inject(PLATFORM_ID) private platformId, + @Inject(PLATFORM_ID) private platformId ) { this.documentIsAccessible = isPlatformBrowser(this.platformId); } @@ -173,7 +173,7 @@ export class CookieService { path?: string, domain?: string, secure?: boolean, - sameSite?: 'Lax' | 'None' | 'Strict', + sameSite?: 'Lax' | 'None' | 'Strict' ): void { if (!this.documentIsAccessible) { return; @@ -218,7 +218,7 @@ export class CookieService { options.secure = true; console.warn( `[ngx-cookie-service] Cookie ${name} was forced with secure flag because sameSite=None.` + - `More details : https://github.com/stevermeister/ngx-cookie-service/issues/86#issuecomment-597720130` + `More details : https://github.com/stevermeister/ngx-cookie-service/issues/86#issuecomment-597720130` ); } if (options.secure) { From d7e5db4377438d25c1820e356c447c29e97e2e91 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Jadda <17564080+pavankjadda@users.noreply.github.com> Date: Wed, 27 Oct 2021 17:55:58 -0400 Subject: [PATCH 3/4] Update ci.yml --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0ab25ed..e771731 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,8 @@ jobs: - name: Format check run: npm run format:check - name: Build - run: npm run build -- --prod + run: npm run build --configuration=production - name: Test - run: npm run test -- --configuration=ci + run: npm run test --configuration=ci env: CI: true From 3cf64a875aa65848bf81f7fc22f06198ada53be5 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Jadda <17564080+pavankjadda@users.noreply.github.com> Date: Fri, 29 Oct 2021 12:03:06 -0400 Subject: [PATCH 4/4] chore(cicd): switches cicd and build Node version to 16.x (#178) Switches cicd and build Node version to 16.x as NodeJS 16.x switched to LTS version --- .github/workflows/ci.yml | 4 ++-- .github/workflows/npm_publish.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e771731..b894af6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,10 +12,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 14.x + - name: Use Node.js 16.x uses: actions/setup-node@v1 with: - node-version: 14.x + node-version: 16.x - name: Install dependencies run: npm ci - name: Lint diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index e06494a..4f8d868 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -11,7 +11,7 @@ jobs: - uses: actions/checkout@v1 - uses: actions/setup-node@v1 with: - node-version: 14 + node-version: 16 - name: Install Angular CLI run: npm install -g @angular/cli @angular/core - name: Install NPM Dependencies