Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering does not work properly with federation gateway #625

Closed
iamcrookedman opened this issue Sep 10, 2024 · 2 comments
Closed

Ordering does not work properly with federation gateway #625

iamcrookedman opened this issue Sep 10, 2024 · 2 comments

Comments

@iamcrookedman
Copy link

iamcrookedman commented Sep 10, 2024

I'm not sure if this is a problem with this library but definitely the current ordering design doesn't work with @apollo/gateway.

The sort order depends on the order of the keys and when requesting the server directly it works as it should, but when requesting through the federation the order of the keys changes to alphabetical.
Perhaps the ordering body should be an array to avoid dependence on the order of the keys.
I understand that this is a big change in design but in this case we are dependent on how the dictionaries are implemented in one or another part of the system.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@najeeb-thalakkatt
Copy link

Same issue here

@bellini666
Copy link
Member

Hi @iamcrookedman ,

Yeah, this is the same issue as this one: #615

I think the way to solve this will be to revamp the pagination stuff to use an array, just like you said

Going to close this as duplicated, to keep the related discussion in the same place :)

@bellini666 bellini666 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants