deprecate monitor.sh

[bennlich]

monitor.sh is a simple and lovely script that reduces the output of ip route into two numbers: a count of unique routes and a count of unique gateways, and POSTs this info to the monitor server. Exitnodes run this script periodically in a cron job.

Ever since we started publishing entire routing tables with the post-routing-table.sh script, monitor.sh became redundant. With access to the entire list of routes, the server can calculate the two counts on its own.

This work overlaps #41 a bit--getMonitorUpdates() can be modified to fetch the most recent logs from mongo (instead of fetching the memcache key).

cc @thedig -- might be a good issue for you if you're interested cause it touches the exitnode repo too.

[ghost]

https://github.com/sudomesh/monitor/blob/master/post-routing-table.sh is a regular post request.
https://github.com/sudomesh/monitor/blob/master/monitor.sh is a json request.

The json request is incompatible with the regular post request. https://github.com/sudomesh/monitor/blob/master/src/app.js needs to be changed so the same post url can be accepted, the same content header text/plain or application/json, and the post data needs to be by parameters or a new key/value pair inside app.js.

[bennlich]

@jnull I was thinking we should just obliterate https://github.com/sudomesh/monitor/blob/master/monitor.sh altogether.

The current situation in app.js looks something like this in pseudocode:

function receiveCounts(numGatewaysAndRoutes) {
  saveNumGatewaysAndRoutes(numGatewaysAndRoutes);
}

function receiveRouteTable(routes) {
  saveRoutes(routes);
}

monitor.sh hits receiveCounts and post-routing-table.sh hits receiveRouteTable. (Note that these are not the real names in the code. In app.js, receiveCounts is https://github.com/sudomesh/monitor/blob/master/src/app.js#L122-L137 and receiveRoutes is https://github.com/sudomesh/monitor/blob/master/src/app.js#L144-L216.)

I'm thinking we should simplify the exitnodes and stop sending counts. We only need to send routes. We would change the monitor logic to something like:

function receiveRouteTable(routes) {
  numGatewaysAndRoutes = countGatewaysAndRoutes(routes);
  saveNumGatewaysAndRoutes(numGatewaysAndRoutes);
  saveRoutes(routes);
}

How's that?

[ghost]

So i understand, you don't think we need these two fields for each exit node: `

[eenblam]

The idea is not to get rid of those values, but that the monitor app can compute them from routing table data. Doing so would make monitor.sh redundant, meaning it can be removed.

…

On Wed, Jun 12, 2019 at 4:17 PM Jared Null ***@***.***> wrote: So i understand, you don't think we need these two fields for each exit node: `[image: Screen Shot 2019-06-12 at 16 15 35] <https://user-images.githubusercontent.com/3529087/59392712-7d7e8880-8d2d-11e9-9fa7-167516e66ef9.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#42?email_source=notifications&email_token=AA3Y62N2TL5O4FNSC4N7MVDP2F7YHA5CNFSM4GQ5EBT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSBXCA#issuecomment-501488520>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3Y62NE6V3RCEX5PYRVHFTP2F7YHANCNFSM4GQ5EBTQ> .

[ghost]

i ran $DATA from https://github.com/sudomesh/monitor/blob/master/post-routing-table.sh:

root@hurricane:/home/null# (ip route | grep via | grep -v default | awk '{print $1 "," $3 }' | sort | uniq | tr '\n' '|')
100.65.0.0/26,100.65.0.1|100.65.0.64/26,100.65.0.65|100.65.127.128/26,100.65.127.129|100.65.127.130,100.65.127.129|100.65.127.131,100.65.127.129|100.65.127.192/26,100.65.127.193|100.65.131.192/26,100.65.131.193|100.65.132.64/26,100.65.132.65|100.65.134.192/26,100.65.134.193|100.65.137.192/26,100.65.137.193|100.65.139.128/26,100.65.132.65|100.65.142.0/26,100.65.142.1|100.65.142.192/26,100.65.142.1|100.65.143.0/26,100.65.143.1|100.65.144.64/26,100.65.143.1|100.65.145.128/26,100.65.145.129|100.65.146.128/26,100.65.146.129|100.65.146.131,100.65.146.129|100.65.146.64/26,100.65.146.65|100.65.146.66,100.65.146.65|100.65.148.0/26,100.65.148.1|100.65.148.64/26,100.65.148.65|100.65.17.192/26,100.65.17.193|100.65.24.0/26,100.65.24.1|100.65.91.64/26,100.65.91.65|100.65.95.64/26,100.65.95.65|100.65.96.64/26,100.65.96.65|100.65.98.0/26,100.65.98.1|100.65.98.2,100.65.98.1|100.65.99.64/26,100.65.99.65|100.65.99.66,100.65.99.65|

I'm guessing gateways are all ending octect is .1 and everything else between | is a node? and comma separates routes?