Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NEEWER-GL1 PRO Color Temperature: 2900K~7000K #87

Open
CV8R opened this issue Apr 25, 2024 · 9 comments
Open

Support for NEEWER-GL1 PRO Color Temperature: 2900K~7000K #87

CV8R opened this issue Apr 25, 2024 · 9 comments

Comments

@CV8R
Copy link

CV8R commented Apr 25, 2024

Hi,

I have purchased a NEEWER GL1 PRO and logs show that cannot set to Color Temperature: 2900K. I am reporting this as some feedback only because it appears that it sets the light to the lowest color temp anyway (compared with native app).

reports: >> --temp (29) isn't between the bounds of 32 and 85, so falling back to closest start boundary of 32

https://neewer.com/products/neewer-gl1-pro-15-5-key-light-streaming-light-66602110

Dimming Range: 0 to 100
Color Temperature: 2900K to 7000K

This is a CCT only light.

Initially I was using the main branch and could only turn the light on and off, no dimming our color temp. I then found this issue and post which got it working https://github.com/taburineagle/NeewerLite-Python/issues/36#issuecomment-1079921234.

I am now using the WIP-HTTP-Server-Mods branch and same note in the logs.

Cheers and thanks!

@taburineagle
Copy link
Owner

Hi @CV8R - are you saying that you can set the color temperature and brightness, you just can't dial it down to 2900K?

@CV8R
Copy link
Author

CV8R commented Apr 29, 2024

Correct, at least it reports that in the logs. But visually, I think its working when compared to the native app.

@taburineagle
Copy link
Owner

taburineagle commented Apr 30, 2024

Got you - I know what's happening then! For some reason (I don't think I've quite gotten the entire way to changing the entire CLI/HTTP interface with the changes I've done over the past few months), the values of 3200K and 8500K are hard-coded into the tester for that parameter, so the program sees 2800K as invalid, even though it isn't, specifically this line:

testValid("temp", args.temp, 56, 32, 85), - it tests to see if the value is between 32(00K) and 85(00)K, and returns false if it isn't... I need to change this in the next commit.

Also, one other question - how exactly does your light show up in NeewerLite-Python (in other words, is it listed as "GL1PRO", "GL1 Pro", "GL1 PRO", etc.)? I have a section of pre-defined light parameters that should recall the correct settings for that light, but apparently it's not pulling the right data as it's not listed in that list (I have parameters for the GL1 and GL1C, but none yet for the GL1 Pro), hence the initial issue where the light would only turn on/off.

@CV8R
Copy link
Author

CV8R commented Apr 30, 2024

The light is identified as NEEWER-GL1 PRO - Successful link on light [NEEWER-GL1 PRO] MAC Address:

@taburineagle
Copy link
Owner

taburineagle commented Apr 30, 2024

Got you - OK, if you use the latest WIP-HTTP-Server-Mods commit, and delete the custom preference file, does that come up with the correct parameters for the light? It's still going to give that --temp (29) error if you use a color temperature under 3200K until I change that in the next commit, but that version should properly set the other parameters correctly (that it's a CCT-only light that uses a color temp range of 2900-7000K) as it does have CL1 in the master list of lights, and the CL1 Pro uses the same parameters as the CL1.)

@CV8R
Copy link
Author

CV8R commented Apr 30, 2024

Got you - OK, if you use the latest WIP-HTTP-Server-Mods commit, and delete the custom preference file, does that come up with the correct parameters for the light? It's still going to give that --temp (29) error if you use a color temperature under 3200K until I change that in the next commit, but that version should properly set the other parameters correctly (that it's a CCT-only light that uses a color temp range of 2900-7000K) as it does have CL1 in the master list of lights, and the CL1 Pro uses the same parameters as the CL1.)

I believe so yes, visually, when compared to the native app the color temp looks correct. When you push the next commit I will try it again to ensure the log is not reporting --temp (29) error.

taburineagle added a commit that referenced this issue May 5, 2024
Extended the CCT temperature range from 3200K-8500K to 2500K-10000K - addresses #87.
@taburineagle
Copy link
Owner

OK, I've pushed a new commit to the WIP-HTTP-Server-Mods branch - it extends the range of CCT temperatures settable by the CLI/HTTP interface to 2500K-10000K... this should take care of the issue you were having before @CV8R.

@CV8R
Copy link
Author

CV8R commented May 15, 2024

Apologies for the delay. I have been traveling.

The color temp errors are now gone in the log and it the temp is changed on the light. I note though, that if I add &on to turn it on the color temp and brightness are ignored. Is there a way to go from off to on and set the brightness and temp?

@taburineagle
Copy link
Owner

Hi @CV8R - ha, well, my delay is a lot longer 😄 Sorry about that! Yeah, at the moment, &on and &off will only turn the light on or off, and not change any settings. This is something I want to take a look at for later versions though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants