From ad6be0f8c18a43fa83fdd98d9469299ef51bac7b Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 22 Dec 2024 20:31:26 +0800 Subject: [PATCH] github: add a step to build "check-include-style" Previously, we do not enforce the policy of including Seastar headers using angle brackets instead of double quotes in our github workflow. In this change, a new step is added to build "check-include-style" target when building the Dev mode. This allows our CI to fail if a change violates this policy. Signed-off-by: Kefu Chai --- .github/workflows/test.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 2e69fa82b6..d3e8ce02a8 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -99,6 +99,10 @@ jobs: if: ${{ inputs.mode == 'dev' && inputs.compiler == 'clang++' }} run: cmake --build build/${{ inputs.mode }} --target checkheaders + - name: Check Include Style + if: ${{ inputs.mode == 'dev' && inputs.compiler == 'clang++' }} + run: cmake --build build/${{ inputs.mode }} --target check-include-style + - name: Build with C++20 modules if: ${{ contains(inputs.enables, 'cxx-modules') }} run: cmake --build build/${{ inputs.mode }} --target hello_cxx_module