Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Methods without ActivityMethod attribute are registered as Activities #382

Open
roxblnfk opened this issue Jan 5, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@roxblnfk
Copy link
Collaborator

roxblnfk commented Jan 5, 2024

Describe the bug

We have an incorrect behavior regarding Activity: all methods of ActivityInterface classes are scanned and added as activity methods, instead of only registering methods with the ActivityMethod attribute only. This leads to even class constructors being included in the activity list.

Additional context

Despite the fact that the documentation everywhere instructs the user to use attributes to mark activity methods, there is a chance that not everyone followed this.
I propose to solve the problem in 2 stages:

  • First, we will inform the user that they are calling an activity method that is not marked with an attribute. We will immediately remove constructors and other magic methods from scanning.
  • After some time, we will completely disable the registration of activity methods without attributes.
@roxblnfk roxblnfk added the Bug Something isn't working label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant