From 97cca39bac323b39e4ddce86538d2555e67af57b Mon Sep 17 00:00:00 2001 From: sephster Date: Thu, 26 Nov 2020 11:09:48 +0000 Subject: [PATCH 1/3] Pass Key object instead of string to JWT configuration --- src/Entities/Traits/AccessTokenTrait.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Entities/Traits/AccessTokenTrait.php b/src/Entities/Traits/AccessTokenTrait.php index 26007188f..d60ff9f1c 100644 --- a/src/Entities/Traits/AccessTokenTrait.php +++ b/src/Entities/Traits/AccessTokenTrait.php @@ -46,7 +46,9 @@ public function initJwtConfiguration() { $privateKeyPassPhrase = $this->privateKey->getPassPhrase(); - $verificationKey = empty($privateKeyPassPhrase) ? InMemory::plainText('') : $privateKeyPassPhrase; + $verificationKey = empty($privateKeyPassPhrase) ? + InMemory::plainText('') : + InMemory::plainText($this->privateKey->getPassPhrase()); $this->jwtConfiguration = Configuration::forAsymmetricSigner( new Sha256(), From 28ced051ae4b6bd6a6b7b3ff6abb0d3bde552dcc Mon Sep 17 00:00:00 2001 From: sephster Date: Thu, 26 Nov 2020 11:11:34 +0000 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f49eba4b1..5304cee74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] +## [8.2.1] - released 2020-11-26 +### Fixed +- If you have a password on your private key, it is now passed correctly to the JWT configuration object. (PR #XXXX) + ## [8.2.0] - released 2020-11-25 ### Added - Add a `getRedirectUri` function to the `OAuthServerException` class (PR #1123) From a88fcac219dcff73233b3141fbff8cf6c1ff01f0 Mon Sep 17 00:00:00 2001 From: sephster Date: Thu, 26 Nov 2020 11:16:49 +0000 Subject: [PATCH 3/3] Update changelog --- CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5304cee74..f6b6e6dff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [8.2.1] - released 2020-11-26 ### Fixed -- If you have a password on your private key, it is now passed correctly to the JWT configuration object. (PR #XXXX) +- If you have a password on your private key, it is now passed correctly to the JWT configuration object. (PR #1159) ## [8.2.0] - released 2020-11-25 ### Added @@ -515,7 +515,8 @@ Version 5 is a complete code rewrite. - First major release -[Unreleased]: https://github.com/thephpleague/oauth2-server/compare/8.2.0...HEAD +[Unreleased]: https://github.com/thephpleague/oauth2-server/compare/8.2.1...HEAD +[8.2.1]: https://github.com/thephpleague/oauth2-server/compare/8.2.0...8.2.1 [8.2.0]: https://github.com/thephpleague/oauth2-server/compare/8.1.1...8.2.0 [8.1.1]: https://github.com/thephpleague/oauth2-server/compare/8.1.0...8.1.1 [8.1.0]: https://github.com/thephpleague/oauth2-server/compare/8.0.0...8.1.0