Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide a way for repository owners to opt out #143

Open
jacobian opened this issue Sep 14, 2022 · 1 comment
Open

Please provide a way for repository owners to opt out #143

jacobian opened this issue Sep 14, 2022 · 1 comment

Comments

@jacobian
Copy link

Not all repository owners want to recieve automated pull requests.

In some cases, the PRs aren't even actionable -- consider the case of a vendored dependancy that contains a typo. The maintainer can't fix it without forking upstream, which could cause a merge conflict if they wanted to upgrade. This is pretty common in Python web stuff that needs to include upstream JavaScript code, for example.

For some maintainers, the time-to-value ratio isn't there for these kinds of PRs. Typo PRs of this nature increases noise, makes it harder to focus on the issues they'd like to work on. For others, having a bunch of open PRs increases stress. For some, the very idea of automated PRs is frustrating; see, for example, this thread by Dustin Ingram: https://twitter.com/di_codes/status/1542489151630712832


You've built a tool that can be useful, but also can be used in a way that feels mildly abusive. I think the compassionate thing to do would be to build a mechanism for repository owners to opt out. I can think of a few ways to do this:

  • some sort of central blocklist here in this repo that maintainers can add repos (or entire projects/usernames) to
  • a metadata file in a repo, e.g. a robots.txt for repositories
  • some sort of well-known tag (no-automated-prs-please) owners could add to their repos

I'm sure there are other solutions. Please consider implementing one.

@timgates42
Copy link
Owner

Yes there is a black list currently

# Organisations or Users who have requested to be excluded from typo fixes
BLACKLISTED_ORGUSERS = {"angvp"}

but I do like your other suggestions too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants