Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add padding to FullGridCellList bounding box? #80

Open
efaulhaber opened this issue Nov 14, 2024 · 2 comments
Open

Automatically add padding to FullGridCellList bounding box? #80

efaulhaber opened this issue Nov 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@efaulhaber
Copy link
Member

When a particle is in a boundary cell of the grid, it is not surrounded by cells, so we get an out-of-bounds exception when looking for neighbor cells. Currently, one has to manually add a padding of search_radius to the bounding box.
I think it would be better if the padding was automatically included (only when not using periodicity?) and maybe could be deactivated with padding = false.

@efaulhaber efaulhaber added the enhancement New feature or request label Nov 14, 2024
@sloede
Copy link
Member

sloede commented Nov 14, 2024

Good idea! Maybe the padding could be automatically based on the maximum search radius (I don't know if this can be specified) in case of variable search radius setups?

@efaulhaber
Copy link
Member Author

efaulhaber commented Nov 14, 2024

If we want to do variable search radius with p4est, we don't need a padding, as p4est gives us the actual neighbor cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants