Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pure Float32 computation checks into CI #2211

Open
huiyuxie opened this issue Dec 15, 2024 · 2 comments
Open

Integrate pure Float32 computation checks into CI #2211

huiyuxie opened this issue Dec 15, 2024 · 2 comments
Assignees
Labels

Comments

@huiyuxie
Copy link
Member

I have just refactored my package to support Float32 computation see trixi-gpu/TrixiCUDA.jl#94, so I need to ensure that all the Float32 computations are type stable here at least within rhs! functions (except for some unavoidable Float64 computations).

Type stability checks for single functions is already integrated in CI https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_type.jl, but it is not enough to ensure the type stability for the whole computation process. I will try to integrate a new pure Float32 computation checks into CI like here #2129 (comment) by initializing the tests in an independent environment - but it may fail.

Can you @ranocha help review and give me some suggestions in the process - you clearly know all the problems and contexts.

@huiyuxie huiyuxie self-assigned this Dec 15, 2024
@huiyuxie
Copy link
Member Author

But this definitely add more workload to CI.

@ranocha
Copy link
Member

ranocha commented Dec 16, 2024

Nice idea! Adding a few additional checks for this is fine - but we cannot test every elixir of course. Please feel free to ask me if you have some questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants