Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config: update/add some rules #81

Open
tunnckoCore opened this issue Nov 3, 2019 · 0 comments
Open

eslint-config: update/add some rules #81

tunnckoCore opened this issue Nov 3, 2019 · 0 comments
Labels
Pkg: configs / presets Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.

Comments

@tunnckoCore
Copy link
Owner

tunnckoCore commented Nov 3, 2019

'func-name-matching': ['off', 'always', {
  includeCommonJSModuleExports: true,
  considerPropertyDescriptor: true,
}],
max-len: [
  'error', {
    code: 80,
    comments: 80,
    ignoreUrls: true,
    ignoreStrings: false,
    ignoreRegExpLiterals: true,
    ignoreTemplateLiterals: true,
    ignoreTrailingComments: true,
    ignoreComments: false
  }
]

commonly used CJS will fail:

/* eslint func-name-matching: ["error", "always", { "includeCommonJSModuleExports": true }] */

module.exports = function foo() {};
module['exports'] = function foo() {};

// no errors:

module.exports = () => {};
module['exports'] = () => {};
@tunnckoCore tunnckoCore added Pkg: configs / presets Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR. labels Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pkg: configs / presets Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.
Projects
None yet
Development

No branches or pull requests

1 participant