Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "skip-loading" to bypass changes to irrelevant save file contents #20

Closed
tylercamp opened this issue Jul 4, 2024 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@tylercamp
Copy link
Owner

Pal Calc currently parses the whole save file when reading, which makes the reader sensitive to any format changes in any part of the file.

Pal Calc is only interested in certain sub-structures. A change to an irrelevant part of the file shouldn't cause issues elsewhere in Pal Calc.

We should prefer to parse the whole save file for correctness, but if there's an error, we should fall back to a "skip-loading" process which searches for known markers of relevant sections (e.g. .worldSaveData.CharacterSaveParameterMap) and resumes parsing from that point.

@tylercamp tylercamp added the enhancement New feature or request label Jul 4, 2024
@tylercamp
Copy link
Owner Author

Going to close this without changes. Implementing this would require significant changes and increase drift vs. palworld-save-tools which is used as a reference. In practice this doesn't seem like much of an issue

@tylercamp tylercamp added the wontfix This will not be worked on label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant