Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permit2 approval #21

Closed
rndquu opened this issue Nov 15, 2024 · 4 comments
Closed

Add permit2 approval #21

rndquu opened this issue Nov 15, 2024 · 4 comments

Comments

@rndquu
Copy link
Member

rndquu commented Nov 15, 2024

Depends on #13

If partner selects to add the https://github.com/ubiquity-os-marketplace/text-conversation-rewards plugin then (depending on the config) partner should also be able to set allowances for permit2 contract.

@0x4007
Copy link
Member

0x4007 commented Nov 18, 2024

Are you sure this should be handled in the context of the installer? I understand why you want it but the UIs/tools should be specialized. It might make more sense to have another simple UI for this. Also, soon, we will migrate to "payment permit requests" architecture which means that the key will not be handled by the single plugin.

@rndquu
Copy link
Member Author

rndquu commented Nov 18, 2024

Are you sure this should be handled in the context of the installer?

As far as I understand https://github.com/ubiquity-os/ubiquity-os-plugin-installer should look like a plugins markerplace in the end, not an individual installer.

I understand why you want it but the UIs/tools should be specialized.

For me it's natural to see all plugin install specific installation steps in a single screen without jumping between UI tools. Anyway we could place the "add permit2 approval" UI to a separate repository and put that URL in the https://github.com/ubiquity-os-marketplace/text-conversation-rewards's plugin readme. Since the plan is to show the plugin readme on plugin installation we could put the "add permit2 approval" URL in the plugin's readme so that partner knew what else is required for the plugin to run.

@0x4007
Copy link
Member

0x4007 commented Nov 18, 2024

As far as I understand https://github.com/ubiquity-os/ubiquity-os-plugin-installer should look like a plugins markerplace in the end, not an individual installer.

Thats correct

@rndquu
Copy link
Member Author

rndquu commented Nov 18, 2024

Closing in favor of ubiquity/onboard.ubq.fi#29

@rndquu rndquu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@rndquu rndquu removed this from Development Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants