Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zvážit jinou knihovnu na grafy #42

Closed
14 tasks done
v6ak opened this issue Sep 22, 2023 · 4 comments
Closed
14 tasks done

Zvážit jinou knihovnu na grafy #42

v6ak opened this issue Sep 22, 2023 · 4 comments
Assignees
@v6ak
Labels
ease-future-development
Milestone
2024.0

Comments

@v6ak
Copy link
Owner

v6ak commented Sep 22, 2023 •
edited
Loading

D3.js? Nebo spíše Observable plot? Problém je, že není sama o sobě responzivní, resp. je pro to potřeba trošku kódu, který se postará o překreslení.

Hlavní

Globální grafy

  • Genderová struktura
  • Čas/start
  • Počet lidí
  • Počet lidí v %

Osobní grafy

  • Rychlost
  • Pauzy
  • Chůze

Detaily

  • Porovnání startu a času: bubliny někdy zasahují moc vlevo
  • Viděl jsem v konzoli nějaký error
  • Porovnání startu a času by možná chtělo detailnější popisky bublin
  • Zkusit na telefonu
  • Telefon: fixnout „tančení" grafů
  • Cukání na telefonu, když se skrývá/ukauzje adresní řádek

Po merge

  • Rebase feature/no-age-info
@v6ak v6ak added this to the 2024.0 milestone Sep 22, 2023
@v6ak v6ak self-assigned this Sep 22, 2023
@v6ak v6ak mentioned this issue Sep 28, 2023
Closed
6 tasks
@v6ak
Copy link
Owner Author

v6ak commented Oct 13, 2023 •
edited
Loading

Chart.js vypadá též dobře a umí být responzivní. Navíc je v plné palbě menší (205kB) než jen základ jquery.jqplot.js (172kB) + jQuery (84kB).

This was referenced Oct 13, 2023
Closed
Closed
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Use Chart.js for gender structure and start/duration plots #42
a6086a8
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Remaining participant plots for #42
c32fc52
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Use Chart.js for gender structure and start/duration plots #42
7adc295
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Rewrite remaining participant plots to Chart.js (#42)
5365fe1
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Use Chart.js for gender structure and start/duration plots (#42)
993269a
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Rewrite remaining participant plots to Chart.js (#42)
1891963
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Remove age structure plot (#42)
9e7c00e
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Rewrite all individual charts from jqPlot to Chart.js and get rid of …
8679ce0 
…jqPlot and jQuery (#42)
@v6ak
Copy link
Owner Author

v6ak commented Oct 14, 2023 •
edited
Loading

Velikost:

  • Předběžně jsme na 1.11MiB JS (bylo 1.24MiB), tedy -0.13MiB. A to původně jsme měli výběr z jqplot (+jQuery), teď máme zatím celé Chart.js + plugin pro Moment.js.
  • S Přejít z jsdependencies na scalajs-bundler #56 čekám, že se JS ještě zmenší.
  • Došlo i k mírnému zmenšení CSS.

UI:

  • Lepší popisky
  • Reaguje na změnu velikosti okna (popř. překlopení telefonu), s výjimkou velikosti bublin v grafu Porovnání startu a času
  • Grafy s počty účastníků zohledňují různé vzdálenosti stanovišť
  • IMHO lepší vzhled

v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Rewrite all individual charts from jqPlot to Chart.js and get rid of …
b246447 
…jqPlot and jQuery (#42)
v6ak added a commit that referenced this issue Oct 14, 2023
@v6ak
Start/time chart fine-tuning (#42)
0b8912a
@v6ak
Copy link
Owner Author

v6ak commented Oct 14, 2023

Vypadá to, že jsem narazil na chartjs/Chart.js#11224 .

v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Fix plot jumping (#42)
d9461c4
@v6ak
Copy link
Owner Author

v6ak commented Oct 15, 2023

Snad vyřešeno. Přidal jsem kvůli ratio cca 5KiB CSS, což odpovídá zhruba odstraněnému CSS kvůli jqPlotu.

v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Make pie charts smaller (#42)
a27b268
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Fix artifacts when scrolling on phone (caused by onresize triggered b…
862adc7 
…y navbar hiding/showing) (#42)
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Use Chart.js for gender structure and start/duration plots (#42)
10edfe1
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Rewrite remaining participant plots to Chart.js (#42)
b01421b
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Remove age structure plot (#42)
4468fa9
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Rewrite all individual charts from jqPlot to Chart.js and get rid of …
156033c 
…jqPlot and jQuery (#42)
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Start/time chart fine-tuning (#42)
c36c85c
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Fix plot jumping (#42)
425b533
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Make pie charts smaller (#42)
f5bafd4
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Fix artifacts when scrolling on phone (caused by onresize triggered b…
c0d6d4b 
…y navbar hiding/showing) (#42)
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Use Chart.js for gender structure and start/duration plots (#42)
30a1cea
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Rewrite remaining participant plots to Chart.js (#42)
edbf856
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Remove age structure plot (#42)
c46247c
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Rewrite all individual charts from jqPlot to Chart.js and get rid of …
9e12d35 
…jqPlot and jQuery (#42)
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Start/time chart fine-tuning (#42)
5c0f708
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Fix plot jumping (#42)
435d039
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Make pie charts smaller (#42)
dde8451
v6ak added a commit that referenced this issue Oct 15, 2023
@v6ak
Fix artifacts when scrolling on phone (caused by onresize triggered b…
1f77fc1 
…y navbar hiding/showing) (#42)
@v6ak v6ak closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v6ak v6ak

Labels
ease-future-development
Projects
None yet
Milestone
2024.0
Development

No branches or pull requests
1 participant
@v6ak