Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock Location issue with FastImporterService #3287

Open
ankitdev10 opened this issue Dec 21, 2024 · 2 comments · May be fixed by #3288
Open

Stock Location issue with FastImporterService #3287

ankitdev10 opened this issue Dec 21, 2024 · 2 comments · May be fixed by #3288
Assignees
@ankitdev10
Labels
P3: minor Non-critical, no workarounds exist type: bug 🐛 Something isn't working @vendure/core

Comments

@ankitdev10
Copy link

Describe the bug
With fast importer service, initialized with a seller's channel, the product variant gets assigned to the default stock location despite passing the seller's stock location.

To Reproduce
Steps to reproduce the behavior:

  1. Initialize the FastImporterService with a seller's channel
  2. Use it to import product variants
  3. Pass the stockLevels to the createProductVariant method with the stockLocationId of the seller's channel

Expected behavior
When the stock location id is provided the variant should be assigned to that particular stock location and not the default one.

Environment (please complete the following information):

  • @vendure/core version: 3.0.5
  • Nodejs version 20
  • Database (mysql/postgres etc): postgres

Additional context
It is a small fix and I would like to contribute to it as I have managed to make it work locally with the marketplace my team is building
@ankitdev10 ankitdev10 added the type: bug 🐛 Something isn't working label Dec 21, 2024
ankitdev10 added a commit to ankitdev10/vendure that referenced this issue Dec 21, 2024
@ankitdev10
fix(core): Fix issue with fast-importer-service assignment with stock…
8abac7e 
… location to the variants

this commit fixes the issue
vendure-ecommerce#3287
@michaelbromley michaelbromley added @vendure/core P3: minor Non-critical, no workarounds exist labels Dec 30, 2024
@michaelbromley
Copy link
Member

Hi, thanks for the report. A PR would be welcome!

@ankitdev10
Copy link
Author

Hi, I already have a PR opened here

@ankitdev10 ankitdev10 linked a pull request Dec 30, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitdev10 ankitdev10

Labels
P3: minor Non-critical, no workarounds exist type: bug 🐛 Something isn't working @vendure/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): Fix issue with fast-importer-service stock location ankitdev10/vendure
2 participants
@michaelbromley @ankitdev10