Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend NodeInfo of NetApi #627

Open
niklr opened this issue Sep 20, 2022 · 0 comments
Open

extend NodeInfo of NetApi #627

niklr opened this issue Sep 20, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@niklr
Copy link
Contributor

niklr commented Sep 20, 2022

The response returned by invoking the net_nodeInfo RPC method should be extended with the following properties:

  • port (e.g. 8483)
  • filePort (e.g. 8484)
  • addressSignature (can be empty, see below)

The address property already exists but is always empty. This property should be used to return the PublicAddress specified in the node_config.json configuration file.

The addressSignature property should be the signature generated by ed25519.Sign(privateKey, address). The signature can then be verified with ed25519.Verify(node.ID.Bytes(), address, signature) assuming that node.ID.Bytes() is the publicKey of the privateKey used to generate the signature. (Note: will be empty if address is empty) Similar to:

sign := ed25519.Sign(mineKey, node.ID.Bytes())

Additionally, the response returned by invoking the dashboard_processInfo RPPC method should be extended with the following properties:

  • httpPort (e.g. 48132, omitted if HTTP is not enabled)
  • wsPort (e.g. 41420, omitted if WS is not enabled)
@niklr niklr added the enhancement New feature or request label Sep 20, 2022
@niklr niklr self-assigned this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant