testFileDir always matches

[timbrinded]

Describe the bug

Given the tree:

.
├── tests1
│   └── test.spec.ts
├── tests11
│   └── test.spec.ts
└── tests2
    └── test.spec.ts

Vitest will match tests1 & tests11 when supplied with filter tests1/.

Whilst i recognise that you can use the include option or even specifying direct filenames, that is a very heavyhanded and hardcoded approach which doesn't fit large test repositories (in my case i have 400+ test files in nested directories).

Instead it would be less-surprising for it to match based on inputs such as tests1/ to only use that directory. A regex \b would also be acceptable.

Reproduction

Using this StackBlitz you can execute the following scripts that illustrates a plausible scenario:

• pnpm test:all : ✅
• pnpm test:1 : ❌ - Runs tests for both folder1 and folder11
• pnpm test:2 : ✅
• pnpm test:11 : ✅

Important

In reality, most scenarios wouldn't be matching based on numbers, but i've got into weird scenarios where expressions collide with each other: test_blocks and test_blockscope

System Info

all

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitest-dev-vitest-grbmeo (Open reproduction)

[sheremet-va]

Yes, the filter is just string.includes(), this is expected. You need to provide / yourself

[timbrinded]

if you see the repro, the filter contains the / but it is being ignored

[timbrinded]

@sheremet-va did you see the comment above? The defect appears valid to me.

[sheremet-va]

You are correct, this is a bug. It probably happens because of this check (relative removes all / at the end):

vitest/packages/vitest/src/node/workspace.ts

Line 255 in 7dee832

return testFile.includes(f) || testFile.includes(relative(dir, f))

To fix this, we should append / if it was there before relative was called.

[ibuibu]

I challenge to contribute.