-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vitest typecheck
does not find test files in typecheck.include
#4432
Comments
Start a new pull request in StackBlitz Codeflow. |
…ta.2 - vitest-dev/vitest#4432 Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>
There is no such command anymore. Typechecking runs alongside normal tests now, but you need to pass down --typecheck |
ok. is there a way to make this clear to users? given what you said, i would have expected |
This is mentioned in documentation. "typecheck" is a valid filter. I guess, we can throw an error until 2.0 if you think this is a valid concern 🤔 |
docs are great, but throwing an error would be more helpful - especially when running vitest during a ci workflow. all of my workflows that include typechecks passed even though my files were not found. throwing an error will cause the workflow, thus leading most developers to review the documentation, and make it clear that edit: release notes wise, it would also be helpful if the |
Describe the bug
Test files specified in
typecheck.include
are no longer found when runningvitest typecheck --run
.This seems to be a regression of some sort, given that this is not an issue in previous versions (
<=1.0.0-beta.2
).Reproduction
https://stackblitz.com/edit/vitest-typecheck-bug?file=vitest.config.ts
System Info
Used Package Manager
yarn
Validations
The text was updated successfully, but these errors were encountered: