New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task that fail with `close: true` no longer notify user of errors #51646

Open

vscodenpa opened this issue Jul 31, 2024 · 0 comments

Owner

vscodenpa commented Jul 31, 2024

Have a task that will fail and close, such as this one (or the prelaunch task in vscode)

    {
      "label": "My Task",
      "type": "shell",
      "command": "exit 1",
      "problemMatcher": [],
      "presentation": {
            "close": true
      }
    },

run it
Expect to see the usual error notification, but instead observe an "InstatiationService has been disposed" console error from

https://github-com/microsoft/vscode/blob/6f2764acf84f4eb2c751f0ee635c057965a8147f/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts-L1614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment