Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataPicker e DataPickerRange #2048

Open
lafray opened this issue Jan 3, 2025 · 0 comments · May be fixed by #2049
Open

DataPicker e DataPickerRange #2048

lafray opened this issue Jan 3, 2025 · 0 comments · May be fixed by #2049
Assignees
@lafray
Labels
bug Something isn't working

Comments

@lafray
Copy link
Contributor

lafray commented Jan 3, 2025

Problem

O componenete se desabilita quando recebe a prop isDisabled porém visualmenete não fica desabilitado como os outros campos

Expected behavior

espera-se que o campo assumisse a cor cinza de background disabled quando rece a prop isDisabled

Reproducible Example

https://codesandbox.io/p/sandbox/shoreline-data-picker-5jdxt3?file=%2Fsrc%2FApp.tsx%3A18%2C19

Suggested solution

change from data-disabled to aria-disabled

nesta linha para DataRangePicker e nesta linha para DataPicker

Additional context

No response

Package

No response

Packages version

No response

Browser

No response

Package Manager

pnpm
@lafray lafray added the bug Something isn't working label Jan 3, 2025
@lafray lafray self-assigned this Jan 3, 2025
@lafray lafray moved this to Active in Shoreline Jan 3, 2025
lafray added a commit that referenced this issue Jan 3, 2025
@lafray
fix(data-picker): update style when field is disabled
c687c6c 
Updates the styles to pick up correctly when the field is disabled and also leaves the calendar
button disabled

fix #2048
lafray added a commit that referenced this issue Jan 3, 2025
@lafray
fix(data-range-picker): update style when field is disabled
6bb77c8 
Updates the styles to pick up correctly when the field is disabled and also leaves the calendar
button disabled

fix #2048
@lafray lafray linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lafray lafray

Labels
bug Something isn't working
Projects
Shoreline
Status: Active
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust date-picker disabled prop vtex/shoreline
1 participant
@lafray