Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more event types #28

Open
ohmyguigs opened this issue Jan 31, 2018 · 1 comment
Open

Handle more event types #28

ohmyguigs opened this issue Jan 31, 2018 · 1 comment

Comments

@ohmyguigs
Copy link
Contributor

Event property must be string, number or boolean.
When it's an object or array, we should try to stringify and if it is not possible, only show warning and log the rest of the event without the problematic field. (it's bad to lose events just because you forgot to stringify your array 😂 )

@lbebber
Copy link

lbebber commented May 3, 2018

Was gonna open an issue just like this one. I did this on inStore, should probably do something similar here. https://github.com/vtex/checkout-instore/pull/535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants