-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn/matches.re.xml: re00984 unicode-version #6
Comments
It would be a shame to put that dependency on the whole test - better to move the relevant part into a separate test with a dependency.
Michael Kay
… On 19 Aug 2019, at 18:20, Zachary Dean ***@***.***> wrote:
Test re00984 tests a large number of code-points for the \w character sequence.
Characters ⌈ and ⌉ are in this list. These codepoints were moved from \p{S} to \p{P} in unicode version 6.3, and therefore out of the \w character sequence.
Perhaps the test should include the "unicode-version" dependency flag for version "6.2"?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AASIQIU2NDBFSFJP7XPA2NLQFLI6LA5CNFSM4IND6ULKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGBKPQA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASIQIUHFAAG2QFROF6EZ7DQFLI6LANCNFSM4IND6ULA>.
|
@michaelhkay You make a very good point, and a separate test for the reclassified characters is definitely the better answer. I took a quick look through the notes for the unicode updates since 6.3 and only found a few more category changes, but none that seem to break things in the current test suite as it stands. Just a side note: |
Test re00984 tests a large number of code-points for the
\w
character sequence.Characters
⌈
and⌉
are in this list. These codepoints were moved from\p{S}
to\p{P}
in unicode version 6.3, and therefore out of the\w
character sequence.Perhaps the test should include the "unicode-version" dependency flag for version "6.2"?
The text was updated successfully, but these errors were encountered: