Windows Undercurl Support

[rawhat]

What Operating System(s) are you running on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20240206-225705-4f123a46

Ask your question!

I didn't want to either pollute the existing issues, or create a new one without fully understanding the situation.

I previously asked on one of the issues (#415 (comment)) about undercurl support. This was identified as an unsupported feature in ConPTY.

From what I can tell, the linked issue in the microsoft/terminal repository is now resolved? 🎉

My question is... does this unlock that functionality for WezTerm? If so, would there need to be changes made? I did try installing the new preview version of the MS Terminal, and did not see any change in wezterm. Which may be expected, just noting it.

Just curious about this, since it'd be nice to not have to SSH into WSL to get this functionality. Not really a big deal either way.

Thanks!

[rawhat]

It'd probably help to have done any investigation before creating this... I see in the code that it prefers the vendored conpty.dll in the assets/windows/conhost directory. So I guess my question is answered that "yes, this probably needs to be updated for this to work". But also seems like a minimal change 😄

[akthe-at]

@Daydreamer-riri and the wezterm version?

[Daydreamer-riri]

@akthe-at It's 20240203-110809-5046fc22

Should I use the Nightly version?

[akthe-at]

@Daydreamer-riri I am using nightly but I thought that version should work? Regardless, if you copy this to the terminal outside of neovim does it work?

printf "\x1b[58:2::255:0:0m\x1b[4:1msingle\x1b[4:2mdouble\x1b[4:3mcurly\x1b[4:4mdotted\x1b[4:5mdashed\x1b[0m\n"

[akthe-at]

,@Daydreamer-riri I don't remember if you need to modify that print test for powershell or not

Write-Host "`e[58:2::255:0:0m`e[4:1msingle`e[4:2mdouble`e[4:3mcurly`e[4:4mdotted`e[4:5mdashed`e[0m"

[Daydreamer-riri]

‌‌I found that it works after I started using the Nightly version...

[akthe-at]

Oh man oh man...we are cooking

[antoineco]

I just stumbled upon this comment, thanks for the heads up!

It even works in Neovim as of wezterm 20240513-190755-f1a08426: