🐛 [Bug] v5.1.1 - Why are there always some weird ts-check issues?

[JakiChen]

Astro Info

Astro                    v5.1.1
Node                     v20.18.0
System                   macOS (x64)
Package Manager          yarn
Output                   server
Adapter                  @astrojs/vercel
Integrations             @storyblok/astro
                         astro-robots
                         @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

不能将类型“string”分配给类型“never”。
Type 'string' is not assignable to type 'never'.

What's the expected result?

It is expected that the following configuration will not cause ts-check errors in versions 3.0.0 and above and 4.0.0 and above.

// @ts-check
import { defineConfig } from 'astro/config';

import { env, vite } from './config';
import { storyblok, sitemap, robots } from './config/integrations';

// https://astro.build/config
export default defineConfig({
  site: env.SITE_URL,
  //
  scopedStyleStrategy: 'attribute',
  build: {
    inlineStylesheets: 'never',
    assets: '_app',
    format: 'file',
    // assetsPrefix: env.SITE_URL
  },
  image: {
    domains: ['a.storyblok.com'],
  },
  //
  i18n: {
    locales: ['en', 'zh-CN'],
    defaultLocale: 'zh-CN',
  },
  //
  vite,
  //
  ...(await import('./config/vercel/server')).default,
  //
  integrations: [
    storyblok,
    robots,
    sitemap,
  ]
});

Tip

I am beginning to wonder why astro check is removed by default in versions 5.0.0 and above, and what inexplicable changes have been made.

Link to Minimal Reproducible Example

See repository

Participation

• I am willing to submit a pull request for this issue.

[sinskiy]

Spreading another config after i18n key (..(await import("./config/vercel/server")).default) breaks your types.
There is a simpler and more logical solution for TypeScript, but you don't use TypeScript, so you can move your Vercel config above i18n key:

// @ts-check
import { defineConfig } from "astro/config";

import { env, vite } from "./config";
import { storyblok, sitemap, robots } from "./config/integrations";
+ import vercel from "config/vercel/server"

// https://astro.build/config
export default defineConfig({
  site: env.SITE_URL,
+ ...vercel,
  //
  scopedStyleStrategy: "attribute",
  build: {
    inlineStylesheets: "never",
    assets: "_app",
    format: "file",
    // assetsPrefix: env.SITE_URL
  },
  image: {
    domains: ["a.storyblok.com"],
  },
  //
  i18n: {
    locales: ["en", "zh-CN"],
    defaultLocale: "zh-CN",
  },
  //
  vite,
  //
- ...(await import("./config/vercel/server")).default,
  //
  integrations: [storyblok, robots, sitemap],
});

[JakiChen]

I've debugged according to astro docs and config and it seems to fix the issue on its own.

So here comes the question: why can't it be configured like before 4.0.0, and the interface hasn't changed much, the question is inexplicable, 5.0.0 is really attractive.

Hopefully, the Astro team will be able to improve the issue or have it clearly documented.

// @ts-check
import { defineConfig } from 'astro/config';

import { env, vite } from './config';
import { favicons, storyblok, sitemap, robots } from './config/integrations';

// https://astro.build/config
export default defineConfig({
  site: env.SITE_URL,
  trailingSlash: 'ignore',
  //
  ...(await import('./config/vercel/server')).default,
  //
  vite,
  integrations: [
    favicons,
    storyblok,
    robots,
    sitemap,
  ],
  //
  compressHTML: import.meta.env.PROD,
  scopedStyleStrategy: 'attribute',
  security: {
    checkOrigin: true,
  },
  build: {
    format: 'file',
    inlineStylesheets: 'never',
    assets: '_app',
    // assetsPrefix: env.SITE_URL
  },
  image: {
    domains: ['a.storyblok.com'],
  },
  //
  i18n: {
    locales: ['zh-CN', 'zh-HK', 'en'], defaultLocale: 'zh-CN'
  },
});