-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable other extensions to activate ff2mpv #112
Comments
I'm not necessarily opposed to this, but I don't know how to do it. If someone were to send a patch and an explanation of how it works, I'd be happy to merge it and include it in the next release. |
I just recently added some changes in the code for migrating to mv3 that could be used for this. I'm talking specifically for the listener for According to the documentation // External extension
chrome.runtime.sendMessage(ff2mpvExtensionId, { type: 'openVideo', url }, callback);
// ff2mpv
chrome.runtime.onMessageExternal.addListener((request, _sender, sendResponse) => {
const { type, url } = request;
...
case 'openVideo':
ff2mpv(url);
return sendResponse('ok');
...
}); I believe that the listener could be included before merging the mv3 migration (so this works with the current version). Update: It requires to use |
I've opened a PR with the changes for this to work #113 |
Thank you! |
Addressed by #113. Please file a new issue after that's released if you're still seeing problems here. |
Is your feature request related to a problem? Please describe.
I would like to integrate ff2mpv with vimium c, as requested here. But it seems that ff2mpv doesn't have the interface to allow other extensions to activate it.
Describe the solution you'd like
A way that extensions could activate ff2mpv.
The text was updated successfully, but these errors were encountered: