Race condition on Node.js SSR renderer?

[benoitv-code]

Hi! I am looking into integrating internalization in Astro Node.js standalone SSR, and I've had a look at astro-i18next.

Looking at the implementation, there is something I don't understand (but maybe I got something wrong, if so, please let me know what I missed 🙏):

• i18next seems to use a global instance when using changeLanguage() and importing t from "i18next"
• Astro seems to be rendering pages asynchronously (= multiple pages could be rendered in parallel if awaiting for an async operation to complete)
• astro-i18next Node.js standalone example uses changeLanguage from "i18next"

Due to this, it seems that a call to changeLanguage() could affect other Astro renderings happening in parallel (which could result in part of the page / server-side components being rendered with another language).

What do you think? Do you think it would be a limitation when using the Node.js renderer? (cc @yassinedoghri)

[yassinedoghri]

Hey @benoitv-code, sorry for the late reply.

Have you experienced this? If so, I'm guessing that would explain it.

[benoitv-code]

Hi! I didn't experience it directly as I was only looking into the different implementations and I noticed this issue here, so I wanted to make sure you were aware of it.

I know some people use Astro to run it on the edge, which I believe has a dedicated instance for each render, so it wouldn't be an issue there (maybe it's your use case too).

[yassinedoghri]

I see, haven't had anyone report the issue, but I'll keep this in mind if it happens. Thanks for the heads up!

[ninjaa]

I have been experiencing this race condition and it has been hell! Any idea on how to fix it?