Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parametrized composer version #116

Closed
Insolita opened this issue Jan 2, 2021 · 8 comments
Closed

add parametrized composer version #116

Insolita opened this issue Jan 2, 2021 · 8 comments

Comments

@Insolita
Copy link

Insolita commented Jan 2, 2021

Allow composer 2.x version by env/arg

@Insolita
Copy link
Author

Insolita commented Jan 2, 2021

Can add pr

@schmunk42
Copy link
Contributor

Since fxp asset-plugin is not compatible with v2 yet I'd wait until fxpio/composer-asset-plugin#334 is ready.

I'd then switch completely to v2, instead of builiding another 3-4 images.

@Insolita
Copy link
Author

Insolita commented Jan 2, 2021

That issue not solved for more than half of the year, and I'm not sure that anybody works on this. As a fact composer-asset-plugin mostly required for old yii versions only. The newest ones work perfectly with asset-packagist.org So, for 2.x we can skip its installation (and hirak/prestissimo too)

@schmunk42
Copy link
Contributor

@Insolita Could you try adding

RUN composer self-update

to your Dockerfile and see if things are working OK for you?

We, for example, are still using fxp/asset-plugin for most of our projects, because in many of our projects we run into memory issues with asset-packagist (depends on the packages you use).

@Insolita
Copy link
Author

Insolita commented Jan 5, 2021

I also remove "hirak/prestissimo" before update composer version. It works well.

Do you think about the switch to https://github.com/fxpio/foxy with https://github.com/krissss/foxy-yii2-convert ?

I understand that there are many different use cases for this image, so I think that the building parameter that declared which major composer version should be used is the best decision. In our latest yii2 projects we use asset-packagist without problems

@schmunk42
Copy link
Contributor

I also remove "hirak/prestissimo" before update composer version. It works well.

Yes, no longer needed, parallelization is built in composer v2.

@anasjaghoub
Copy link

I fixed it by adding
RUN composer self-update --2 to the Dockerfile

@schmunk42
Copy link
Contributor

schmunk42 commented Aug 19, 2022

We have composer 2 on the Docker images since a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants